Return-Path: 
 <dev-return-24620-apmail-harmony-dev-archive=harmony.apache.org@harmony.apache.org>
Delivered-To: apmail-harmony-dev-archive@www.apache.org
Received: (qmail 55923 invoked from network); 1 Mar 2007 11:50:47 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 1 Mar 2007 11:50:47 -0000
Received: (qmail 28888 invoked by uid 500); 1 Mar 2007 11:50:51 -0000
Delivered-To: apmail-harmony-dev-archive@harmony.apache.org
Received: (qmail 28566 invoked by uid 500); 1 Mar 2007 11:50:50 -0000
Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@harmony.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@harmony.apache.org>
List-Post: <mailto:dev@harmony.apache.org>
List-Id: <dev.harmony.apache.org>
Reply-To: dev@harmony.apache.org
Delivered-To: mailing list dev@harmony.apache.org
Received: (qmail 28557 invoked by uid 99); 1 Mar 2007 11:50:50 -0000
Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Mar 2007 03:50:50 -0800
X-ASF-Spam-Status: No, hits=1.3 required=10.0
	tests=RCVD_NUMERIC_HELO,SPF_HELO_PASS,SPF_PASS,UPPERCASE_25_50
X-Spam-Check-By: apache.org
Received-SPF: pass (herse.apache.org: domain of gcjhd-harmony-dev@m.gmane.org
 designates 80.91.229.2 as permitted sender)
Received: from [80.91.229.2] (HELO ciao.gmane.org) (80.91.229.2)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Mar 2007 03:50:38 -0800
Received: from list by ciao.gmane.org with local (Exim 4.43)
	id 1HMjnU-00030b-IV
	for dev@harmony.apache.org; Thu, 01 Mar 2007 12:50:08 +0100
Received: from 195.161.50.68 ([195.161.50.68])
        by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
        id 1AlnuQ-0007hv-00
        for <dev@harmony.apache.org>; Thu, 01 Mar 2007 12:50:08 +0100
Received: from gshimansky by 195.161.50.68 with local (Gmexim 0.1 (Debian))
        id 1AlnuQ-0007hv-00
        for <dev@harmony.apache.org>; Thu, 01 Mar 2007 12:50:08 +0100
X-Injected-Via-Gmane: http://gmane.org/
To: dev@harmony.apache.org
From: Gregory Shimansky <gshimansky@gmail.com>
Subject: Re: svn commit: r512802 -
 /harmony/enhanced/drlvm/trunk/build/build.bat
Date: Thu, 01 Mar 2007 14:49:55 +0300
Lines: 105
Message-ID: <es6el4$62h$1@sea.gmane.org>
References: <6e47b64f0702282153p7068e498pf47c49df069d9694@mail.gmail.com>
	 <es6c7p$u9j$1@sea.gmane.org>
 <6e47b64f0703010328x1bc9861ah35fd5bc64fdb384@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Complaints-To: usenet@sea.gmane.org
X-Gmane-NNTP-Posting-Host: 195.161.50.68
User-Agent: Thunderbird 1.5.0.7 (Windows/20060909)
In-Reply-To: <6e47b64f0703010328x1bc9861ah35fd5bc64fdb384@mail.gmail.com>
Sender: news <news@sea.gmane.org>
X-Virus-Checked: Checked by ClamAV on apache.org

Stepan Mishura wrote:
> On 3/1/07, Gregory Shimansky wrote:
>>
>> Stepan Mishura wrote:
>> > Hi Gregory,
>> >
>> > Your commit broke my script for building snapshot :-)
>> >
>> > What I should do if Mirosoft Visual Studio is located on D:?
>>
>> Does it help to set CXX=msvc?
> 
> 
> No, it doesn't because COMPILER_CFG_SCRIPT env. value is ignored now. For
> example, federated build sets it:
>            <env key="CXX" value="msvc"/>
> but it won't work if Microsoft Visual Studio was installed to non-standard
> location.

Now I see what you are talking about.

> I suggest reverting the commit a bit - if COMPILER_CFG_SCRIPT is defined
> goto to configuring.

Agreed. I like the change. Could you commit it yourself?

> For example,
> 
> Index: working_vm/build/build.bat
> ===================================================================
> --- working_vm/build/build.bat (revision 513119)
> +++ working_vm/build/build.bat (working copy)
> @@ -47,6 +47,8 @@
> GOTO DEFAULT_COMPILER
> 
> :MSVC_COMPILER
> +IF DEFINED COMPILER_CFG_SCRIPT GOTO CHOOSE_ARGS
> +
> REM Try Platform SDK first
> SET COMPILER_CFG_SCRIPT=C:\Program Files\Microsoft Platform SDK\SetEnv.Cmd
> IF EXIST "%COMPILER_CFG_SCRIPT%" GOTO CHOOSE_ARGS
> @@ -79,14 +81,18 @@
>     )
> )
> 
> +IF DEFINED COMPILER_CFG_SCRIPT GOTO RUN_COMPILER_CONFIGURATION
> SET COMPILER_CFG_SCRIPT=C:\Program
> Files\Intel\Compiler\C++\9.0\IA32\Bin\iclvars.bat
> IF EXIST "%COMPILER_CFG_SCRIPT%" GOTO RUN_COMPILER_CONFIGURATION
> GOTO NO_CFG_SCRIPT
> 
> :X86_64_CONFIG
> +SET PLATFORM_64BIT=amd64
> +
> +IF DEFINED COMPILER_CFG_SCRIPT GOTO RUN_COMPILER_CONFIGURATION
> +
> REM Select Microsoft Visual Studio 2005 on Windows x64 edition
> SET COMPILER_CFG_SCRIPT=C:\Program Files (x86)\Microsoft Visual Studio
> 8\VC\vcvarsall.bat
> -SET PLATFORM_64BIT=amd64
> IF EXIST "%COMPILER_CFG_SCRIPT%" GOTO RUN_COMPILER_CONFIGURATION
> 
> :NO_CFG_SCRIPT
> 
> 
> -Stepan.
> 
>> -----Original Message-----
>> > From: gshimansky@apache.org [mailto:gshimansky@apache.org]
>> > Sent: Wednesday, February 28, 2007 9:31 PM
>> > To: commits@harmony.apache.org
>> > Subject: svn commit: r512802 -
>> > /harmony/enhanced/drlvm/trunk/build/build.bat
>> >
>> > Author: gshimansky
>> > Date: Wed Feb 28 07:30:41 2007
>> > New Revision: 512802
>> >
>> > URL: http://svn.apache.org/viewvc?view=rev&rev=512802
>> > Log:
>> > Applied HARMONY-3255 [drlvm][winx64][build] COMPILER_CFG_SCRIPT must be
>> set
>> > automatically
>> >
>> > Build seems to work ok on both x86 and x86_64 windows platforms
>> >
>> > Modified:
>> >    harmony/enhanced/drlvm/trunk/build/build.bat
>> >
>> > Modified: harmony/enhanced/drlvm/trunk/build/build.bat
>> >
>> > <SNIP>
>> >
>>
>>
>> -- 
>> Gregory
>>
>>
> 
> 


-- 
Gregory