Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 6996 invoked from network); 4 Mar 2007 18:30:54 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 4 Mar 2007 18:30:54 -0000 Received: (qmail 33207 invoked by uid 500); 4 Mar 2007 18:31:00 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 33181 invoked by uid 500); 4 Mar 2007 18:31:00 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 33167 invoked by uid 99); 4 Mar 2007 18:31:00 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 04 Mar 2007 10:31:00 -0800 X-ASF-Spam-Status: No, hits=1.4 required=10.0 tests=SPF_HELO_PASS,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (herse.apache.org: 216.86.168.178 is neither permitted nor denied by domain of geir@pobox.com) Received: from [216.86.168.178] (HELO mxout-03.mxes.net) (216.86.168.178) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 04 Mar 2007 10:30:50 -0800 Received: from [192.168.1.104] (unknown [67.86.14.213]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by smtp.mxes.net (Postfix) with ESMTP id B0D3651943 for ; Sun, 4 Mar 2007 13:30:28 -0500 (EST) Mime-Version: 1.0 (Apple Message framework v752.3) In-Reply-To: <843dd4f00703032048x7b10e037t49fabb8cf23e8ad8@mail.gmail.com> References: <211709bc0702270142k6d513af1g1e51133ae753a0c6@mail.gmail.com> <2c9597b90702280218m54979a51x6c705ae18a1aeabb@mail.gmail.com> <211709bc0702281838v14e78798kd1d61910487207a7@mail.gmail.com> <2c9597b90703010150k17266c17l3cc2768730cadc3a@mail.gmail.com> <1BF65799-9356-4B41-82A4-6330177C421C@pobox.com> <843dd4f00703032048x7b10e037t49fabb8cf23e8ad8@mail.gmail.com> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: "Geir Magnusson Jr." Subject: Re: [classlib][test]how to set up a http proxy server for unit test. Date: Sun, 4 Mar 2007 13:30:26 -0500 To: dev@harmony.apache.org X-Mailer: Apple Mail (2.752.3) X-Virus-Checked: Checked by ClamAV on apache.org On Mar 3, 2007, at 11:48 PM, Ruth Cao wrote: > 2007/3/3, Geir Magnusson Jr. : >> >> Why not leave them in the exclude list? > > > Since in some tests (i.e. > tests.api.java.net.HttpURLConnectionTest), we can > get all the test cases out of the exclude list using Jetty except > the one > which needs a proxy server. If we comment out the related one, more > test > cases can be run continuously. Got it. Too bad there isn't a notation for excluding specific tests, rather than just test classes : org.apache.harmony.whatever.Foo#testWoogie > > Also, what do we need from Jetty? > > > We need a ProxyHandler that can start an embeded proxy server. > Jetty 6 has a > plan to implement it, but it seems that it won't be available in a > short > time[1] :-) > > [1] http://www.nabble.com/Jetty6-proxy-handler-t2721411.html > > Greg and Jan are really great >> people, and may be willing to help us out, especially when they find >> out that the World's First Implementation of Open Source Java needs >> it :) >> >> geir >> >> On Mar 1, 2007, at 1:50 AM, Alexei Zakharov wrote: >> >> >> that's not a bad idea, we can find all TODOs in exclude lists >> rather >> >> than src code. >> > >> > Yes, this is exactly what I mean. >> > >> > Thanks, >> > >> > 2007/3/1, Tony Wu : >> >> Thanks Alexei, >> >> >> >> that's not a bad idea, we can find all TODOs in exclude lists >> rather >> >> than src code. >> >> I'll try if no one object. >> >> >> >> On 2/28/07, Alexei Zakharov wrote: >> >> > Hi Tony, >> >> > >> >> > IIRC we have agreed that commenting out test code is not the >> best >> >> > possible solution. Can we just split off proxy-related tests >> into a >> >> > separate test class (ProxyTest for example) and >> then put >> >> > this new class to exclude list? >> >> > >> >> > Thanks, >> >> > >> >> > 2007/2/27, Tony Wu : >> >> > > Hello all, >> >> > > I have been working on moving out the exclude tests in >> >> java.net these >> >> > > days. Some of them need a proxy server. IIRC we have adopted >> >> jetty to >> >> > > avoid external server dependencies before, but >> unfortunately, the >> >> > > ProxyHandler of Jetty has not been implemented yet. So I >> >> purpose to >> >> > > comment out the proxy related testcases and move out the test >> >> class >> >> > > from exclude list. I'll add a TODO in the code and wait for >> the >> >> > > upcoming new version of Jetty. >> >> > > >> >> > > Another way is tha find out another tool to set up a proxy >> >> server. In >> >> > > my opinion, we'd better not import another dependency if >> >> possible. And >> >> > > if it is not an embedding server, we have to write some ugly >> >> code in >> >> > > order to run test automatically. >> >> > > >> >> > > suggestions?concerns? >> > >> > -- >> > Alexei Zakharov, >> > Intel ESSD >> >> > > > -- > Best regards, > > Ruth Cao > China Software Development Lab, IBM