Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (herse.apache.org: domain of xiaofeng.li@gmail.com
 designates 66.249.82.233 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=OuONM1SohYdIp97AiKz5Da9AUq+zJdnNIKfYyLggmK7L6D4WY/5ijT2fCXrMrP7g00zX9pbD9CF1nfO4OubMvVsPoAcg9bEkDUWAXb7TspzgdRv1V2AGPqVeuepIkkfRal+fGyTyYo2wKFgzmxn7rjN627xw8aqAPEbXQtWnoCA=
Message-ID: <9623c9a50703290539m201aefaase1eb898ea1efae56@mail.gmail.com>
Date: Thu, 29 Mar 2007 20:39:50 +0800
From: "Xiao-Feng Li" <xiaofeng.li@gmail.com>
To: dev@harmony.apache.org
Subject: Re: [drlvm][stability][winx64] finalization tests irregular failure
In-Reply-To: <ca4b22060703290524v5c6a17e2r3e8ded8ac9d52f2f@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <ca4b22060703290501x1221f42eifbbae09a80a16e7b@mail.gmail.com>
	 <9623c9a50703290509k2c213973pf036e8b31936375b@mail.gmail.com>
	 <ca4b22060703290524v5c6a17e2r3e8ded8ac9d52f2f@mail.gmail.com>

Pavel, The number of files doesn't necessarily mean the change is big.
But anyway, I'd like to have a double check.

Thanks.
xiaofeng

On 3/29/07, Pavel Rebriy <pavel.rebriy@gmail.com> wrote:
> Xiao Feng,
>
> There is list of files in vm which influence by the patch in HARMONY-3485:
>
> Index: vm/include/open/gc.h
> Index: vm/include/open/vm_gc.h
> Index: vm/include/open/hythread_ext.h
> Index: vm/thread/src/hythr.def
> Index: vm/thread/src/thread_native_condvar.c
> Index: vm/vmcore/include/finalizer_thread.h
> Index: vm/vmcore/include/ref_enqueue_thread.h
> Index: vm/vmcore/include/finalize.h
> Index: vm/vmcore/src/jni/jni.cpp
> Index: vm/vmcore/src/init/finalize.cpp
> Index: vm/vmcore/src/init/vm_init.cpp
> Index: vm/vmcore/src/init/finalizer_thread.cpp
> Index: vm/vmcore/src/init/ref_enqueue_thread.cpp
>
> If I role back the changes, tests pass.
>
> On 29/03/07, Xiao-Feng Li <xiaofeng.li@gmail.com> wrote:
> >
> > Pavel, the commit H3485 has nothing to do with the execution if GCv5
> > is not used. Please check the few lines of the commit in vmcore, it's
> > only a declaration of an exported function, no real functionality is
> > introduced. I'd like to know how you came to your conclusion. For
> > example, have you tried with Harmony with revision before 521690?
> >
> > Thanks,
> > xiaofeng
> >
> > On 3/29/07, Pavel Rebriy <pavel.rebriy@gmail.com> wrote:
> > > Stability on WinX64 was drastically reduced after HARMONY-3485 was
> > committed
> > > at revision 521690. I created a JIRA issue HARMONY-3523 [1].
> > >
> > > P.S. BTW why HARMONY-3485 is still open if the patch is already
> > committed?
> > >
> > > [1] https://issues.apache.org/jira/browse/HARMONY-3523
> > >
> > > --
> > > Best regards,
> > > Pavel Rebriy
> > >
> >
>
>
> --
> Best regards,
> Pavel Rebriy
>