Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (herse.apache.org: domain of weldonwjw@gmail.com designates
 64.233.182.185 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:mime-version:content-type;
        b=ipFZ4F2q62/z9BqdEiDquGaq7lxVtTZmyMqV3BOM+v7pZXEre+FlVBnhq9oOkADjKTt8npIgY+cDnjM1WzjssnSseAaSlUM4I2KxRnLZp7XLtZnLGbKZcJUnYR9hubifaofGKIxFf99TDVpDV8z23KITUjwEZJKmNQHcxI8tfME=
Message-ID: <4dd1f3f00703181539i76a0550fse56a77c4d45fa383@mail.gmail.com>
Date: Sun, 18 Mar 2007 15:39:10 -0700
From: "Weldon Washburn" <weldonwjw@gmail.com>
To: dev@harmony.apache.org
Subject: [drlvm][threading] questions about H3413,
 Refactoring exception safepoint callback
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_91816_1638110.1174257550155"

------=_Part_91816_1638110.1174257550155
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Pavel,

The code in this patch looks much better than the original code.  Thanks for
focusing on cleaning this code up.

A question about the use of  the disable_count field in struct hythread_t.
I notice in hythread_exception_safe_point() that the old value of this field
is saved.  The field is then specifically set to a value of one and once the
exception callback is processed, the field is returned to its original
value.  Is this a case where disable_count is actually be overloaded with
another use?  Would it make sense to split the two uses into two seperate,
distinct fields??

-- 
Weldon Washburn
Intel Enterprise Solutions Software Division

------=_Part_91816_1638110.1174257550155--