harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gregory Shimansky <gshiman...@gmail.com>
Subject Re: svn commit: r515047 - in /harmony/enhanced/drlvm/trunk/build/make: targets/ehwa.test.xml test.properties
Date Tue, 06 Mar 2007 12:12:21 GMT
Alexey Varlamov wrote:
> 2007/3/6, Gregory Shimansky <gshimansky@gmail.com>:
>> Hello Alexey
>>
>> After this commit JVMTI test VMInit1 produces lots of warnings when it is
>> ran in default JIT mode. The problem is that default JIT mode is not 
>> truly
>> default because you've specified -client switch for it. In this mode 
>> OPT is
>> enabled, and so some functionality which is needed for JVMTI like
>> get_bc_location_for_native is not available, and returns errors. 
>> That's why
>> VM prints many warning messages.
>>
>> Would it not be better to make jit.switch empty to test the truly default
>> mode instead of client?
> 
> Empty switch behaves unexpectedly on Linux. I just did not realize EM
> automatically switches to "ti" config for JVMTI support, now fixed
> mode argument (at r515086).
> BTW, shouldn't at least some warning be displayed to warn about
> JVMTI-incompatible mode selected?

It is a work in progress to decide which mode is compatible with what 
JVMTI agent has requested, and which is not. For example most if not all 
profiling functionality work just fine with OPT enabled. So if agent is 
satisfied with can_generate_compiled_method_load event, using OPT won't 
cause any problems with JVMTI.

It is necessary to find the features that are JET specific, and if agent 
requests some of them, then use special EM configuration. Otherwise 
JVMTI shouldn't affect the execution mode. But this will make such 
features requestable only on VM startup. So it will be necessary to make 
a choice which way is better, allow dynamic capabilities or allow OPT if 
agent didn't request anything JET specific in its initialization.

>>
>> 2007/3/6, varlax@apache.org <varlax@apache.org>:
>> >
>> > Author: varlax
>> > Date: Tue Mar  6 01:47:11 2007
>> > New Revision: 515047
>> >
>> > URL: http://svn.apache.org/viewvc?view=rev&rev=515047
>> > Log:
>> > Applied HARMONY-3276 and HARMONY-3303 test mode tweaks.
>> >
>> > Modified:
>> >     harmony/enhanced/drlvm/trunk/build/make/targets/ehwa.test.xml
>> >     harmony/enhanced/drlvm/trunk/build/make/test.properties
>> >
>> > Modified: harmony/enhanced/drlvm/trunk/build/make/targets/ehwa.test.xml
>> > URL:
>> > 
>> http://svn.apache.org/viewvc/harmony/enhanced/drlvm/trunk/build/make/targets/ehwa.test.xml?view=diff&rev=515047&r1=515046&r2=515047

>>
>> >
>> > 
>> ============================================================================== 
>>
>> > --- harmony/enhanced/drlvm/trunk/build/make/targets/ehwa.test.xml
>> > (original)
>> > +++ harmony/enhanced/drlvm/trunk/build/make/targets/ehwa.test.xml Tue
>> > Mar  6 01:47:11 2007
>> > @@ -54,7 +54,7 @@
>> >      </target>
>> >
>> >      <target name="run-ehwa">
>> > -        <for list="${ehwa.test.mode}" param="mode"
>> > +        <for list="${test.mode}" param="mode"
>> >              trim="true" keepgoing="true">
>> >              <sequential>
>> >                  <antcall target="-run-ehwa-batch">
>> >
>> > Modified: harmony/enhanced/drlvm/trunk/build/make/test.properties
>> > URL:
>> > 
>> http://svn.apache.org/viewvc/harmony/enhanced/drlvm/trunk/build/make/test.properties?view=diff&rev=515047&r1=515046&r2=515047

>>
>> >
>> > 
>> ============================================================================== 
>>
>> > --- harmony/enhanced/drlvm/trunk/build/make/test.properties (original)
>> > +++ harmony/enhanced/drlvm/trunk/build/make/test.properties Tue Mar  6
>> > 01:47:11 2007
>> > @@ -14,7 +14,7 @@
>> > # of VM execution modes,
>> > # like defined below "jet", "opt" and "int"
>> > #
>> > -test.mode=jet,opt,int
>> > +test.mode=jit,opt,int
>> >
>> > #--------------------------------------------
>> > #
>> > @@ -52,7 +52,7 @@
>> > #                                      beware to avoid empty switch
>> >
>> > jit.name=Client mode JIT (default)
>> > -jit.switch=-Dbogus
>> > +jit.switch=-client
>> >
>> > jet.name=jitrino.JET
>> > jet.switch=-Xem:jet
>> > @@ -60,8 +60,8 @@
>> > opt.name=jitrino.OPT
>> > opt.switch=-Xem:opt
>> >
>> > -srv.name=jitrino.SRV
>> > -srv.switch=-Xem:server
>> > +srv.name=Server mode JIT
>> > +srv.switch=-server
>> >
>> > int.name=interpreter
>> > int.switch=-Xint
>> > @@ -70,10 +70,6 @@
>> > #
>> > #  Eclipse HelloWorld development scenario (aka EHWA)
>> > #
>> > -#  ehwa.test.mode      comma separated list of modes to run EHWA on
>> > -
>> > -ehwa.test.mode=jet,opt,int
>> > -
>> > # Locations to obtain platform specific Eclipse SDK bundle
>> > # A bundle will be downloaded and stored for local use, unless
>> > # ECLIPSE_HOME environment variable points to existing Eclipse
>> > installation
>> >
>> >
>> >
>>
>>
>> -- 
>> Gregory
>>
> 


-- 
Gregory


Mime
View raw message