harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Petrenko" <alexey.a.petre...@gmail.com>
Subject Re: [classlib][vmi] managing default properties
Date Mon, 19 Mar 2007 07:12:16 GMT
In fact Evgenia has rised this question on dev list a month ago while
preparing the patch :)

Regarding default properties I agree that we need a way to set default
classlib properties in classlib. On of the main reasons for this
approach that Harmony has more VMs then classlibs :)

As a solution I would suggest a DefaultProperties (or smth like that)
class in java.lang or org.apache.harmony.smth package to incorporate
all the default properties for classlib.

Do we really need separate properties for each module?

SY, Alexey

2007/3/19, Alexey Varlamov <alexey.v.varlamov@gmail.com>:
> I think we should minimize hardcoding classlib specific values to VMs,
> and suggest to reconsider the way this issue is fixed.
> IMO setting the defaults like
> "java.util.prefs.FilePreferencesFactoryImpl" or
> "javax.xml.transform.TransformerFactory" should be done during
> initialization of respective classlib modules, or, if this is
> impossible/inappropriate, added to luni's initialization rather than
> to VM startup.
> Actually there is a bunch of corresponding FIXME comments in the
> modified DRLVM source - let's fix them instead of aggravating.
> Should I reopen the JIRA?
>
> --
> Alexey
>
> 2007/3/17, apetrenko@apache.org <apetrenko@apache.org>:
> > Author: apetrenko
> > Date: Sat Mar 17 01:58:05 2007
> > New Revision: 519267
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=519267
> > Log:
> > Patch for HARMONY-3209 "Harmony's default instance of javax.xml.TransformerFactory
differs from RI's one"
> >
> > Modified:
> >    harmony/enhanced/drlvm/trunk/vm/vmcore/src/init/vm_properties.cpp
> >
> > Modified: harmony/enhanced/drlvm/trunk/vm/vmcore/src/init/vm_properties.cpp
> > URL: http://svn.apache.org/viewvc/harmony/enhanced/drlvm/trunk/vm/vmcore/src/init/vm_properties.cpp?view=diff&rev=519267&r1=519266&r2=519267
> > ==============================================================================
> > --- harmony/enhanced/drlvm/trunk/vm/vmcore/src/init/vm_properties.cpp (original)
> > +++ harmony/enhanced/drlvm/trunk/vm/vmcore/src/init/vm_properties.cpp Sat Mar 17
01:58:05 2007
> > @@ -209,6 +209,10 @@
> >  #else
> >         "java.util.prefs.FilePreferencesFactoryImpl");
> >  #endif
> > +    // Property for xalan.jar
> > +    properties.set("javax.xml.transform.TransformerFactory",
> > +                   "org.apache.xalan.xsltc.trax.TransformerFactoryImpl");
> > +
> >
> >     // Added for compatibility with the external java JDWP agent
> >     properties.set("sun.boot.library.path", base_path_buf);
> >
> >
> >
>

Mime
View raw message