harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Loenko" <mloe...@gmail.com>
Subject Re: [classlib][jndi] Test failure and others
Date Mon, 05 Mar 2007 15:09:25 GMT
OK

Thanks,
Mikhail

2007/3/5, Richard Liang <richard.liangyx@gmail.com>:
> On 3/5/07, Mikhail Loenko <mloenko@gmail.com> wrote:
> > These were probably some Spain characters and the test checked
> > that these characters are allowed in the name and parsed well
> >
> > Once they are replaced with \uXXXX the test's intent is less clear
>
> Yes, but the escape will not change the test purpose. And the file
> looks strange when users are in different locales[1].
>
> [1]http://wiki.apache.org/harmony/TestRdnWhiteBoxDevelopment
>
> >
> > Thanks,
> > Mikhail
> >
> > 2007/3/5, Richard Liang <richard.liangyx@gmail.com>:
> > > Hello Mikhail,
> > >
> > > I have re-convert the file from cp1252 to US-ASCII(revision r514622).
> > > Would you please help to review the update? Thanks a lot.
> > >
> > > Best regards,
> > > Richard
> > >
> > > On 3/5/07, Richard Liang <richard.liangyx@gmail.com> wrote:
> > > > Aha...It's my fault. I will convert it again. Do you think we shall
> > > > set the "Text file
> > > > encoding" as US-ASCII? Thanks a lot.
> > > >
> > > > Best regards,
> > > > Richard
> > > >
> > > > On 3/5/07, Mikhail Loenko <mloenko@gmail.com> wrote:
> > > > > I have "Default (Cp1252)" radiobutton on in Eclipse "Text file
> > > > > encoding" section...
> > > > >
> > > > > 2007/3/5, Richard Liang <richard.liangyx@gmail.com>:
> > > > > > On 3/5/07, Mikhail Loenko <mloenko@gmail.com> wrote:
> > > > > > > Thanks!
> > > > > > >
> > > > > > > How do you check/change file encoding?
> > > > > >
> > > > > > I guess your default file encoding is iso-8859-5. ;-), and use
> > > > > > native2ascii to change it to ascii.
> > > > > >
> > > > > > >
> > > > > > > Thanks,
> > > > > > > Mikhail
> > > > > > >
> > > > > > > 2007/3/5, Richard Liang <richard.liangyx@gmail.com>:
> > > > > > > > On 3/2/07, Mikhail Loenko <mloenko@gmail.com>
wrote:
> > > > > > > > > Hmmm. I can't reproduce that. CCs also run fine...
> > > > > > > > >
> > > > > > > > > the test originally had this line
> > > > > > > > >         assertEquals(8, rdn.toString().getBytes().length);
> > > > > > > > > could you please try to replace it with
> > > > > > > > >         assertEquals(8, rdn.toString().length());
> > > > > > > >
> > > > > > > > Yes, this solution works. I have committed the change.
(I also changed
> > > > > > > > the file encoding from iso-8859-5 to ascii) Thanks
a lot, Mikhail.
> > > > > > > >
> > > > > > > > >
> > > > > > > > > Thanks,
> > > > > > > > > Mikhail
> > > > > > > > >
> > > > > > > > > 2007/3/2, Richard Liang <richard.liangyx@gmail.com>:
> > > > > > > > > > Hello,
> > > > > > > > > >
> > > > > > > > > > The test case org.apache.harmony.jndi.tests.javax.naming.ldap.whitebox.TestRdnWhiteBoxDevelopment.testToString002
> > > > > > > > > > fails on both RI 5.0 and Harmony with the
same message
> > > > > > > > > > "junit.framework.AssertionFailedError: expected:<8>
but was:<14>".
> > > > > > > > > > Could anyone have a look  at it?
> > > > > > > > > >
> > > > > > > > > > Also I cannot edit this test file in Eclipse
because I set the default
> > > > > > > > > > text encoding as "US-ASCII". Do we have
any agreement about Harmony
> > > > > > > > > > source file encoding? Thanks a lot.
> > > > > > > > > >
> > > > > > > > > > Best regards,
> > > > > > > > > > --
> > > > > > > > > > Richard Liang
> > > > > > > > > > China Development Lab, IBM
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > > Richard Liang
> > > > > > > > China Development Lab, IBM
> > > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Richard Liang
> > > > > > China Development Lab, IBM
> > > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > Richard Liang
> > > > China Development Lab, IBM
> > > >
> > >
> > >
> > > --
> > > Richard Liang
> > > China Development Lab, IBM
> > >
> >
>
>
> --
> Richard Liang
> China Development Lab, IBM
>

Mime
View raw message