harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Weldon Washburn" <weldon...@gmail.com>
Subject [drlvm][threading] architecture discussion on IRC (was Removing APR extension functions)
Date Mon, 26 Mar 2007 21:57:56 GMT
Thanks for the patch.  It should be committed at some point.

This really touches on a much larger and more important issue.  There has
been a stream of threading patches from different engineers.  While the
patches are beneficial, the bottom line is that we have been distracted from
focusing on basic drlvm Thread Manager design flaws.  I suggest the top
priority is fixing these design flaws and we should plan our work
accordingly.  Once the basic design problems are dealt with, we can regroup
and re-prioritize.

What this project really needs right now is a (short) list of Harmony
engineers who are working on the threading subsystem and anticipate donating
patches.  It would be good to coordinate this activity.

We also need to have an interactive Harmony discussion of threading
architecture issues.  While dev@harmony is very useful, it is no replacement
for interactive discussion.  It would be great if we can use IRC chat to
hold these discussions.  The intention is that threading decisions would
still be made on the dev list.

Assuming I can get the firewall configured, I will be on IRC freenode in the
next 24 hours to start discussing what to do about DRLVM keeping thread
state in java.lang.Thread object and also C structs.

 *[drlvm][threading] Removing APR extension functions*   Inbox
         *R*eply   [image: Reply to all] Reply to all[image: Forward]
 Forward Print Add Ilya to Contacts list Delete this message Report
phishing Show
original Message text garbled?
 Ilya Berezhniuk <ilya.berezhniuk@gmail.com>    to dev
 show details
 6:15 am (8 hours ago)
    Hello everyone.

I've found that after recently committed H-3288 changes, several APR
extention functions located in 'vm/port/src/thread/linux/apr_thread_ext.c'
and 'vm/port/src/thread/win/apr_thread_ext.c' are not used anymore. All
other functions were rewritten in platform-dependant files of 'hythr' module
and named with 'os_' prefix.
There is one function which is currently used: apr_memory_rw_barrier().

I think we should remove unused functions with duplicating functionality.
apr_memory_rw_barrier() can be renamed in the same way to
os_memory_rw_barrier() and placed to platform-dependant files in 'hythr'
(because only 'hythr' uses this function).

I've created H-3482 and attached patch which does suggested changes.



Weldon Washburn
Intel Enterprise Solutions Software Division

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message