harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Weldon Washburn" <weldon...@gmail.com>
Subject [drlvm][threading] questions about H3413, Refactoring exception safepoint callback
Date Sun, 18 Mar 2007 22:39:10 GMT
Pavel,

The code in this patch looks much better than the original code.  Thanks for
focusing on cleaning this code up.

A question about the use of  the disable_count field in struct hythread_t.
I notice in hythread_exception_safe_point() that the old value of this field
is saved.  The field is then specifically set to a value of one and once the
exception callback is processed, the field is returned to its original
value.  Is this a case where disable_count is actually be overloaded with
another use?  Would it make sense to split the two uses into two seperate,
distinct fields??

-- 
Weldon Washburn
Intel Enterprise Solutions Software Division

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message