harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Weldon Washburn" <weldon...@gmail.com>
Subject Re: [drlvm][threading] H3288 -- the mods look great. Is it ready to commit?
Date Fri, 16 Mar 2007 03:46:53 GMT
On 3/15/07, Nathan Beyer <ndbeyer@apache.org> wrote:
>
> This is the set of patches for replacing APR thread constructs with
> PThread constructs, correct?
>
> I don't have any objections to doing this, but I did have a question
> about the removal of the all APR thread constructs. The patch doesn't
> seem to remove all APR thread references, but indicates that this is
> being completed, what's the status on that?
>
> I think that this patch simplifies things, but I want to make sure we
> also get the full benefit of not having to manage the APR memory pools
> and eliminate the seemingly unused overhead.


Good point.  I did a grep for "apr_" in trunk/working_vm and found over 1600
hits.  And this is after applying H3288.  Clearly there is much more work to
cleaning up the apr problem.

-Nathan
>
> On 3/15/07, Weldon Washburn <weldonwjw@gmail.com> wrote:
> > All,
> > This is a very nice clean patch.  This definitely helps maintainability
> and
> > probably even stability.  I quickly looked at all 10 patches.  build,
> build
> > test passes on win32 and lin32 rhel4.0.  I can't test lin64 yet.  Does
> > anyone have objection if I commit this patch in the next 15 hours?
> >
> > --
> > Weldon Washburn
> > Intel Enterprise Solutions Software Division
> >
>



-- 
Weldon Washburn
Intel Enterprise Solutions Software Division

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message