harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexei Zakharov" <alexei.zakha...@gmail.com>
Subject Re: [classlib][nio_char]Suggest to rename the ConcreteCharsetTest.java
Date Tue, 06 Mar 2007 10:00:53 GMT
+1 from me.

Regards,

2007/3/6, Richard Liang <richard.liangyx@gmail.com>:
> On 3/6/07, Tony Wu <wuyuehao@gmail.com> wrote:
> > Hi all,
> >
> > the ConcreteCharsetTest is an abstract class which extends
> > junit.framework.TestCase. It was inherited by several test classes in
> > the same package. This class itself can not be run as a junt testcase,
> > but we include all the classes as TestCase which ends with *Test* in
> > our build script. I think that's why it is in the exclude list. so, it
> > is reasonable to rename it to AbstractCharsetTestCase or whatever
> > rather than put it in the exclude list.
> >
> > if no one objects, I'll provide a patch for this refactor.
>
> Please go ahead.


-- 
Alexei Zakharov,
Intel ESSD

Mime
View raw message