Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (herse.apache.org: domain of alexey.v.varlamov@gmail.com
 designates 209.85.132.251 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=XrW839bGWVYBXJoi24ScwK00Tet0xy2QPD3P5QCVXKIWqfr8LlGTCS4r20SEoIEhLXKAxyW5CMx5nm//gBhvxnuHBpSmqNh+n8UqCS4mZ0dfiwXAyt1oT1UiEHZXU35Md6kno9dKRLILwLIO6WN0ABNAU0Vx6GJEwNIFkNrgCak=
Message-ID: <f944d83d0702220516g721fcbcl42edfcc05c1e2b1b@mail.gmail.com>
Date: Thu, 22 Feb 2007 19:16:00 +0600
From: "Alexey Varlamov" <alexey.v.varlamov@gmail.com>
To: dev@harmony.apache.org
Subject: Re: [testing][classlib] correct run of one test case
In-Reply-To: <2c9597b90702220133t2e363132o7eda36d8cd674587@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <7273946b0702150256n4c723c7by11c387ca1e833e56@mail.gmail.com>
	 <7273946b0702150300h4621fe32x4d0aaf7455a52d5e@mail.gmail.com>
	 <f944d83d0702150403w6f4a85fbh4ad93fd798e6cd19@mail.gmail.com>
	 <6e47b64f0702152139t1ab789d2r725e8bf8843677d9@mail.gmail.com>
	 <f944d83d0702152241g640c8260h4108d5dc6771d660@mail.gmail.com>
	 <7273946b0702160446h44f62ee5v287109873cc267fd@mail.gmail.com>
	 <7273946b0702202143y16b582e8s9f98b4f5858512ef@mail.gmail.com>
	 <2c9597b90702220133t2e363132o7eda36d8cd674587@mail.gmail.com>

Indeed, why not accept both formats?

2007/2/22, Alexei Zakharov <alexei.zakharov@gmail.com>:
> IMHO the benifit of "dir+file name" approach is the fact that the test
> name can be directly copied from exclude list to command prompt
> without modifications. Theoretically it will be nice if we can support
> both notations.
>
> Thanks,
>
> 2007/2/21, Vladimir Ivanov <ivavladimir@gmail.com>:
> > Is it OK to chenge the notation of test case from "package+class name"
> > to "dir+file name" ie from -Dtest.case=org.apache.harmony.<...> to
> > -Dtest.case=org/apache/.../Test.java?
> > Please, refer to Harmony-3187 for possible patches.
> >
> >  thanks, Vladimir
> >
> >
> > On 2/16/07, Vladimir Ivanov <ivavladimir@gmail.com> wrote:
> > > Issue 3187 was created to track it.
> > >  thanks, Vladimir
> > >
> > > On 2/16/07, Alexey Varlamov <alexey.v.varlamov@gmail.com> wrote:
> > > > 2007/2/16, Stepan Mishura <stepan.mishura@gmail.com>:
> > > > > On 2/15/07, Alexey Varlamov wrote:
> > > > > >
> > > > > > This is also applicable to api vs injected tests, the worst case is
> > > > > > security module which has all 4 types. I'd prefer this to be fixed.
> > > > >
> > > > >
> > > > > Do we really need this option? Why not run the test in this way:
> > > > > modules/lang-management> java -cp
> > > > > bin/impl/:../../depends/jars/junit_3.8.2/junit.jar junit.textui.TestRunner
> > > > > org.apache.harmony.lang.management.OperatingSystemMXBeanImplTest
> > > >
> > > > Well, it is a bit more complex for security - you need to place all
> > > > needed resources to bootclasspath, but prior to this you need to find
> > > > which resources are needed and there they are located :)
> > > > Basically this is a matter of convenience - the same as whole
> > > > "-Dtest.case" feature. So if this is cheap to fix, why not?
> > > >
> > > > >
> > > > > -Stepan.
> > > > >
> > > > > E.g. via adding extra step to detect if the specified test really
> > > > > > belongs to a suite and skipping the run otherwise. Yet not sure what
> > > > > > to do if no such test ever ;)
> > > > > >
> > > > > > --
> > > > > > Alexey
> > > > > >
> > > > > > 2007/2/15, Vladimir Ivanov <ivavladimir@gmail.com>:
> > > > > > > I forgot to add test run example:
> > > > > > > >build.bat -Dbuild.module=lang-management
> > > > > > > -
> > > > > > Dtest.case=org.apache.harmony.lang.management.OperatingSystemMXBeanImplTest
> > > > > > > test
> > > > > > > <snip>
> > > > > > > run-tests-api:
> > > > > > >    [mkdir] Created dir: C:\harmony.top\classlib\trunk\build\test_report
> > > > > > >    [junit] Running
> > > > > > > org.apache.harmony.lang.management.OperatingSystemMXBeanImplTest
> > > > > > >    [junit] Tests run: 1, Failures: 0, Errors: 1, Time elapsed: 0 sec
> > > > > > >    [junit] Test
> > > > > > > org.apache.harmony.lang.management.OperatingSystemMXBeanImplTest
> > > > > > > FAILED
> > > > > > >
> > > > > > > touch-failures-file:
> > > > > > >
> > > > > > > touch-errors-file:
> > > > > > >
> > > > > > > run-tests-impl:
> > > > > > >    [junit] Running
> > > > > > > org.apache.harmony.lang.management.OperatingSystemMXBeanImplTest
> > > > > > >    [junit] Tests run: 7, Failures: 0, Errors: 0, Time elapsed: 0.15 sec
> > > > > > >
> > > > > > > thanks, Vladimir
> > > > > > >
> > > > > > > On 2/15/07, Vladimir Ivanov <ivavladimir@gmail.com> wrote:
> > > > > > > > Hello everybody,
> > > > > > > >
> > > > > > > > when I ran separated TestCase'es I met a small issue: in the case when
> > > > > > > > we have 'api' and 'impl' tests, for example in the lang-management
> > > > > > > > module, any test always failed in one run due to 'NoClassDefFound'.
> > > > > > > >
> > > > > > > > Is it OK to add some elements to classpath or should we change a run a
> > > > > > > > little bit or is it expected behavior?
>
>
>
> --
> Alexei Zakharov,
> Intel ESSD
>