Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (herse.apache.org: domain of gcjhd-harmony-dev@m.gmane.org
 designates 80.91.229.2 as permitted sender)
To: dev@harmony.apache.org
From: Salikh Zakirov <Salikh.Zakirov@Intel.com>
Subject: Re: [testing][drlvm] smoke test gc.WeakReferenceTest failed today
   on winXP
Date: Wed, 07 Feb 2007 16:30:17 +0300
Lines: 36
Message-ID: <eqck9b$c8d$1@sea.gmane.org>
References: <7273946b0701290108o28a4dbd2vfe3d5b2b669b82d7@mail.gmail.com>
	 <epl0d5$tht$1@sea.gmane.org>
	 <7273946b0701300034jda18a70me6fafc1be08a6118@mail.gmail.com>
	 <e79e5b390701300107q724630ebjcca2994ba732dcbe@mail.gmail.com>
	 <783bf8b0701300658u641bdf60vda87194b53c45119@mail.gmail.com>
	 <783bf8b0701300729i5cb5f306x80eb49c9c64cf6df@mail.gmail.com>
	 <7273946b0701310321w5ae5579fib5fbcfab009f2275@mail.gmail.com>
 <e79e5b390701310420l4825c15fmefbf4b78ce3b193a@mail.gmail.com>
 <epq5g4$2vt$1@sea.gmane.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
User-Agent: Thunderbird 1.5.0.9 (Windows/20061207)
In-Reply-To: <epq5g4$2vt$1@sea.gmane.org>
Sender: news <news@sea.gmane.org>

Gregory Shimansky wrote:
> Elena Semukhina wrote:
>> I managed to reproduce the failure on my Windows XP laptop. W'd
>> suggest that
>> we change the test so that it waits a little after gc() as Pavel pointed
>> out.
> 
> Spec says in [1] that
> 
> -------------------
> Some time after the garbage collector determines that the reachability
> of the referent has changed to the value corresponding to the type of
> the reference, it will add the reference to the associated queue. At
> this point, the reference is considered to be enqueued.
> -------------------
> 
> The problem is with defining "some time". If spec says nothing about how
> much time later the reference is enqueued, then it is not possible to
> test such event consistently. I am afraid this test is simply incorrect
> and cannot be used.
> 
> [1]
> http://java.sun.com/j2se/1.5.0/docs/api/java/lang/ref/package-summary.html

I would suggest defining "some time" as a call to System.runFinalization().
It's specification does not mention weak references at all, but it is highly
likely that finalization subsystem is coupled with weak references handling,
so expectation of references being enqueued together with finalization
is not ungrounded.
At least on DRLVM, this should work.

And again, if the references wasn't enqueued after

    System.gc(); System.runFinalization();

on DRLVM, then it would look like a real bug.