harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yang Paulex" <paulex.y...@gmail.com>
Subject Re: [jira][general] Good issue resolution guideline update
Date Tue, 06 Feb 2007 05:43:34 GMT
2007/2/6, Alexey Petrenko <alexey.a.petrenko@gmail.com>:
>
> Guys,
>
> I think we need a little update for the "Good issue resolution guideline"
> [1]
>
> I suggest the following additions to the "Resolving Issues.If the
> issue is a bug" to make committers life much easier :)
> 1. All the newly introduced message strings should be internationalized
> 2. All the patches should have an evaluation comment
> 3. If you change two lines of code please make sure that you patch
> includes only these two lines and do not include any other changes
> like code formatting.
> 4. Add yourself to the list of watchers to receive comments and
> concerns on your patch.


I also had some thoughts to keep the patch history, recently I reviewed and
commented some patches, and then the contributor submitted new
patches(thanks!), but they removed the old ones from JIRA. Sometimes it
makes me confused, because the patches' names are same but they are actually
a new version, further, it makes the former discussion on the JIRA invalid
because they are based on the old patches. So I'd like to propose this for
discussion:

5. if for any reasons, someone needed to submit a new patch for some issue,
don't delete the old one, but named the new ones with version number.


Thoughts? Concerns? Objections?
>
> SY, Alexey
>
> [1] http://harmony.apache.org/issue_resolution_guideline.html
>



-- 
Paulex Yang
China Software Development Labotary
IBM

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message