harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Petrenko" <alexey.a.petre...@gmail.com>
Subject Re: [jira][general] Good issue resolution guideline update
Date Wed, 07 Feb 2007 08:01:40 GMT
2007/2/7, Alex Blewitt <alex.blewitt@gmail.com>:
> On 06/02/07, Tim Ellison <t.p.ellison@gmail.com> wrote:
> > The pack200 code does have to be internationalized -- why would there be
> > an exception for that module?
> Mostly because it's a work-in-progress, and at present when I detect
> an error condition (or part of the parsing tree that I can't handle) I
> throw new Error("Not yet implemented"). In other words, it's a marker
> to let me know I need to go back there and fix it.
It is better to mark such methods by adding NotImplementedException to
throws clause. japitools will catch such methods.

SY, Alexey

> These strings were internationalised into .properties files in an
> earlier change by others, and whilst 'real' messages should be
> internationalised when it's complete, they shouldn't be done so during
> development.
> There's also potentially some constants I've not marked with //
> NON-NLS at present, but like I said, it's a work in progress :-)
> Alex.

View raw message