harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Petrenko" <alexey.a.petre...@gmail.com>
Subject Re: [jira][general] Patch descriptions
Date Fri, 02 Feb 2007 20:36:45 GMT
2007/2/2, Naveen Neelakantam <neelakan@uiuc.edu>:
>
> On Feb 2, 2007, at 9:42 AM, Geir Magnusson Jr. wrote:
>
> >
> > On Feb 2, 2007, at 10:35 AM, Alexey Petrenko wrote:
> >
> >> I've faced the following problem while reviewing suggested patches:
> >> the patches does not have descriptions. It is easy to understand the
> >> patch if it is doing something simple. Like parameters check.
> >> But in more complicated cases description would be great.
> >>
> >> So I vote for including patch description requirement to the "Good
> >> issue resolution guideline" [1].
> >>
> >> Any concerns or objections?
> >>
> >
> > None.  And besides documenting it, feel free to push back on
> > patches that don't have good descriptions.
>
> Before an issue is pushed back, could an email be sent to the
> reporter?  Or maybe a comment could be placed in the JIRA saying that
> the issue is being pushed back?
Sure!

SY, Alexey

> I am *trying* to be helpful when I report bugs, but if I'm doing a
> bad job I want someone to let me know.  It's hard to change if you
> don't know something is wrong.
>
> Naveen
>
> > geir
> >
> >> SY, Alexey
> >>
> >> [1] http://harmony.apache.org/issue_resolution_guideline.html
> >
>
>

Mime
View raw message