harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Markov" <mikhail.a.mar...@gmail.com>
Subject Re: [jira][general] Good issue resolution guideline update
Date Tue, 13 Feb 2007 17:30:27 GMT
Sorry for resuming the discussion - i've missed it last week:

> 2. All the patches should have an evaluation comment

I'm not fully agree with the word "all" and prefer something like "complex"
or "non-trivial" as usually the code says for itself without any additional
comments and the explanation is much longer then the patch itself. Just use
the common sense.

Thoughts?

Thanks,
Mikhail


On 2/5/07, Alexey Petrenko <alexey.a.petrenko@gmail.com> wrote:
>
> Guys,
>
> I think we need a little update for the "Good issue resolution guideline"
> [1]
>
> I suggest the following additions to the "Resolving Issues.If the
> issue is a bug" to make committers life much easier :)
> 1. All the newly introduced message strings should be internationalized
> 2. All the patches should have an evaluation comment
> 3. If you change two lines of code please make sure that you patch
> includes only these two lines and do not include any other changes
> like code formatting.
> 4. Add yourself to the list of watchers to receive comments and
> concerns on your patch.
>
> Thoughts? Concerns? Objections?
>
> SY, Alexey
>
> [1] http://harmony.apache.org/issue_resolution_guideline.html
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message