harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexei Zakharov" <alexei.zakha...@gmail.com>
Subject Re: [jira] Commented: (HARMONY-2957) [classlib][pack200] Update pack200 project layout and ensure 1.4 compatibility
Date Mon, 05 Feb 2007 08:50:25 GMT
Hi Geir and all,

Let me explain what is going on in HARMONY-2957 ([classlib][pack200]
Update pack200 project layout and ensure 1.4 compatibility).
We just trying to finalize the work on this JIRA . The problem was
that currently there are two types of source files in pack200 - 1.4
sources and 1.5 sources. This causes problems while working in IDE
like Eclipse since it is hard (impossible?) to have different compile
targets inside single Eclipse project (or IDEA module). You are
allowed to have either 1.4 compile target or 1.5 compile target.
Alex's proposal was to precompile 1.5 sources, put the jar into svn
and add it to the list of jars the pack200 eclipse project depends on.
I didn't like this approach so we decided just to place a README with
appropriate instructions - i.e. what should be done to make an eclipse
user happy.

Any comments and / or suggestions are highly welcome


2007/2/3, Geir Magnusson Jr (JIRA) <jira@apache.org>:
>     [ https://issues.apache.org/jira/browse/HARMONY-2957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469894
> Geir Magnusson Jr commented on HARMONY-2957:
> --------------------------------------------
> This thread should be on the mailing list - the rest of us have no clue what's going
on here...
> > [classlib][pack200] Update pack200 project layout and ensure 1.4 compatibility
> > ------------------------------------------------------------------------------
> >
> >                 Key: HARMONY-2957
> >                 URL: https://issues.apache.org/jira/browse/HARMONY-2957
> >             Project: Harmony
> >          Issue Type: Improvement
> >          Components: Classlib
> >            Reporter: Alex Blewitt
> >         Assigned To: Alexei Zakharov
> >            Priority: Minor
> >         Attachments: get-rid-of-test-exclusions.patch, pack200-java5.jar, pack200-project.patch,
pack200.patch, pack200.patch
> >
> >
> > This patch adds support for the Eclipse project to be based on 1.4 compatibility,
rather than 1.5 compatibility. I've split the Java source into two; src/main/java and src/main/java5
-- the latter needs to be compiled with a 1.5 system, the former with a 1.4 system. I've amended
the build.xml appropriately to have multiple targets in the appropriate sections, and tested
it out (though I've had to hack the build to get it to work on Mac OS X).
> > I'm pretty sure there's a cleaner way of adding source folders than I've done, but
I'm open to suggestions. The src/main/java needs to be compiled on a 1.4 system, and the src/main/java5
needs to be compiled on a 1.5 (or with 1.5 support, anyway). To make life easier for an Eclipse
developer working on the project in 1.4 mode, the java5 has been exported to pack200-java5.jar
and included in with the patch (though, for some reason, the diff tool doesn't like binary
files so I'm having to attach it manually).
> > I've fixed the SegmentTest; I'm not sure if inheriting this again is a case of deleting
the make/excludes* files; but I've not done that in this patch. I can supply another patch
if this is the case.
> > I've also written a new test to ensure that the compiled class files are generated
with 1.4 compatibility, which should hopefully prevent this form being inadvertently reverted
in the future.
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.

Alexei Zakharov,
Intel ESSD

View raw message