Return-Path: 
 <dev-return-23132-apmail-harmony-dev-archive=harmony.apache.org@harmony.apache.org>
Delivered-To: apmail-harmony-dev-archive@www.apache.org
Received: (qmail 38243 invoked from network); 16 Jan 2007 11:38:21 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 16 Jan 2007 11:38:21 -0000
Received: (qmail 50344 invoked by uid 500); 16 Jan 2007 11:38:27 -0000
Delivered-To: apmail-harmony-dev-archive@harmony.apache.org
Received: (qmail 49769 invoked by uid 500); 16 Jan 2007 11:38:26 -0000
Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@harmony.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@harmony.apache.org>
List-Post: <mailto:dev@harmony.apache.org>
List-Id: <dev.harmony.apache.org>
Reply-To: dev@harmony.apache.org
Delivered-To: mailing list dev@harmony.apache.org
Received: (qmail 49760 invoked by uid 99); 16 Jan 2007 11:38:26 -0000
Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jan 2007 03:38:26 -0800
X-ASF-Spam-Status: No, hits=2.0 required=10.0
	tests=HTML_MESSAGE,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (herse.apache.org: domain of ivavladimir@gmail.com
 designates 66.249.92.168 as permitted sender)
Received: from [66.249.92.168] (HELO ug-out-1314.google.com) (66.249.92.168)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Jan 2007 03:38:17 -0800
Received: by ug-out-1314.google.com with SMTP id z36so1414273uge
        for <dev@harmony.apache.org>; Tue, 16 Jan 2007 03:37:56 -0800 (PST)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=HutoJKVJAp7u3RzMZ6OSurp6VcmIY4MiW8hRjVY7UC25nE/Gv3+Ra9YA6x0FZdWT+8jbd1Qz0YWowvVGYFhb7rk7SWCxF9nzE2kRYIldIL6dhf9T0D5wJ/HG/ZLwklhncikgdU4nKlZX6Mwdj6uPT3fXRpvjangB8ukqXeJ8wWQ=
Received: by 10.82.183.19 with SMTP id g19mr956577buf.1168947474844;
        Tue, 16 Jan 2007 03:37:54 -0800 (PST)
Received: by 10.78.202.1 with HTTP; Tue, 16 Jan 2007 03:37:54 -0800 (PST)
Message-ID: <7273946b0701160337y69f77f3en15745820b9785ab1@mail.gmail.com>
Date: Tue, 16 Jan 2007 17:37:54 +0600
From: "Vladimir Ivanov" <ivavladimir@gmail.com>
To: dev@harmony.apache.org
Subject: Re: [classlib][build] exclude list impl issues
In-Reply-To: <f944d83d0701160308u360558b5j18ceb821c0cddf74@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_58537_15387292.1168947474733"
References: <f944d83d0701160308u360558b5j18ceb821c0cddf74@mail.gmail.com>
X-Virus-Checked: Checked by ClamAV on apache.org

------=_Part_58537_15387292.1168947474733
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On 1/16/07, Alexey Varlamov <alexey.v.varlamov@gmail.com> wrote:

> Folks,
>
> I've some concerns with recent updates for x-list support: can we use
> a common macros instead of copy-pasting 4 new targets into build.xml
> for each module?
> Or, if we can neglect creating a compiled x-file
> (${hy.hdk}/build/<module>.exclude), just use "if" attribute of
> <excludesfile>, like this:
>
> <available property="x.list.exist"
> file="exclude.${hy.platform}.${hy.test.vm.name}"/>
> ...
>            <batchtest>
>                <fileset dir="${src.test.java}">
>                    <include name="**/*Test.java"/>
>                    <excludesfile name="exclude.common"/>
>                    <excludesfile name="${exclude.file} if="x.list.exist"
> />
>                </fileset>
>            </batchtest>



The exclude.common also may be missed.

And I hope in nearest future Harmony will support module-based work so
exclude lists should be copied to somewhere in HDK to run tests. Also I
prefer one exclude list for each module in built space.


Also, I suggest to delete empty x-list remained after introducing common
> lists.
>
> Another issue is with "hy.test.vm.name", it was a surprise for me that
> it is not autodetected yet. Most obvious way to get it is to read
> "java.vm.name" property, this only requires running trivial test.


This feature will be implemented soon.

 Thanks, Vladimir





> --
> Alexey
>

------=_Part_58537_15387292.1168947474733--