Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (herse.apache.org: domain of zhanghuangzhu@gmail.com
 designates 64.233.182.190 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=ag2Um0OFvfAoI1OQP6mR8HdAlRtudXriJ75UYfqmlbk4h4dDf8CoUZeguBQdJ71iMGAPdJRGvlmeGh+kJRUyQ/DPY6RFgjkgN9LI9VZ7WIUWmMs+ROycAKtP5yJ7mfRBgsKbGvlV7XD6IAl2j4orvdb07k95ow6DLLN81R9qfMY=
Message-ID: <4d0b24970701080659v3112090dl26686b6c577e594c@mail.gmail.com>
Date: Mon, 8 Jan 2007 22:59:41 +0800
From: "Andrew Zhang" <zhanghuangzhu@gmail.com>
To: dev@harmony.apache.org
Subject: Re: [classlib] [luni] Ignored Exceptions and HARMONY-2939
In-Reply-To: <fc2fc95c0701080223n52c969cfx9e8b33cc4f161870@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_72650_30830680.1168268381367"
References: <fc2fc95c0701080223n52c969cfx9e8b33cc4f161870@mail.gmail.com>

------=_Part_72650_30830680.1168268381367
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On 1/8/07, Sian January <sianjanuary@googlemail.com> wrote:

> Hello everyone,
>
> I have recently been looking at ignored Exceptions in luni (i.e. places
> where an Exception is caught but the catch block is empty).  These are
> generally a bad idea because if an Exception does occur it is lost - the
> user doesn't see it and it's not logged anywhere either, so if it causes a
> problem in the program it is very difficult to find the root cause.
>
> I would like to discuss one of these in particular, in
> URLCLassLoader.findResources where an IOException and a
> SecurityException are ignored.  Since the signature of the method says
> that
> it throws an IOException (and SecurityException is a subtype of
> RuntimeException) I thought the try-catch block could probably be removed
> entirely.  However it is an API method and I am finding it difficult to
> write a test case for this because I'm not sure how to force either of
> those
> Exceptions.
>
> Geir suggested it might be an interesting topic for the mailing list so
> please post your thoughts.  Also if anyone knows how to write the test
> case
> that would be especially helpful.


I think it's not difficult to write test cases for SecurityException. Write
a specific security manager and set it as system security manager. For this
case, the source code is as follow:
            try {
                sm.checkPermission(result.openConnection().getPermission());
            } catch (IOException e) {
                return null;
            } catch (SecurityException e) {
                return null;
            }
So it's easy to mock a security manager to disable
"result.openConnection().getPermission()",
and write a test to see whether RI returns silently or throws a security
exception. There're many similar tests already in luni module. You may take
a look at SocketTest#test_ConstructorLjava_net_Proxy_Exception() for
reference.

IOException is a bit complicated, maybe you need to mock more things. :-)


>   Details at
> https://issues.apache.org/jira/browse/HARMONY-2939.
>
> Thanks,
>
> Sian
>
> --
> Sian January
>
> IBM Java Technology Centre, UK
>
>


-- 
Best regards,
Andrew Zhang

------=_Part_72650_30830680.1168268381367--