harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anton Luht" <anton.l...@gmail.com>
Subject Re: [DRLVM][building script] Ant version check problem
Date Fri, 12 Jan 2007 09:23:09 GMT
Hello,

I've already filed an issue with patch:

http://issues.apache.org/jira/browse/HARMONY-2869

Please note that the last check for 1.7:

<equals arg1="${ant.sub.sub.version}" arg2="0" />

is wrong and shoulld be removed in future. Now as there's no Ant 1.7.1
it works correctly, though.

On 1/12/07, Xiao-Feng Li <xiaofeng.li@gmail.com> wrote:
> Hi, I am using ant 1.7.0 to build DRLVM, but it is rejected by the scripts.
>
> in working_vm/build/make/setup.xml: line 29
>
>        <math result="ch1" operand1="${ant.version1}" operation="min"
> operand2="1" datatype="int" />
>        <math result="ch2" operand1="${ant.sub.version}"
> operation="min" operand2="6" datatype="int" />
>        <math result="ch3" operand1="${ant.sub.sub.version}"
> operation="min" operand2="5" datatype="int" />
>
>        <fail>
>            <condition>
>                <not>
>                    <and>
>                        <equals arg1="${ch1}" arg2="1" />
>                        <equals arg1="${ch2}" arg2="6" />
>                        <equals arg1="${ch3}" arg2="5" />
>                    </and>
>                </not>
>            </condition>
>
>
> It tries to check the ant version no lower than 1.6.5, but it doesn't
> distinct the three digits in priority. That makes 1.7.0 fail in the
> check, but 0 is smaller than 5.
>
> It needs a logic to pass the check once a higher-order digit is bigger
> than the targeted value. Or the script can compose a single integer
> such as 170 with the three version digits then compare it with 165.
>
> How do you think?
>
> Thanks,
> xiaofeng
>


-- 
Regards,
Anton Luht,
Intel Enterprise Solutions Software Division

Mime
View raw message