harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexei Zakharov" <alexei.zakha...@gmail.com>
Subject Re: [classlib][sql] Re: [jira] Commented: (HARMONY-3017) [classlib][sql] Implementation for SerialClob constructors,getCharacterStream(), and length() methods.
Date Wed, 24 Jan 2007 10:07:03 GMT
Andrew,

It will be nice if you can post a separate patch for manifest or add a
comment to JIRA about what exactly should be changed. I don't use
eclipse currently so I can't test it by myself.

Regards,

2007/1/24, Andrew Zhang <zhanghuangzhu@gmail.com>:
> On 1/23/07, Tim Ellison <t.p.ellison@gmail.com> wrote:
> >
> > Andrew Zhang wrote:
> > > On 1/23/07, Alexei Zakharov <alexei.zakharov@gmail.com> wrote:
> > >> > 2. NIO dependency. Because java.io.Reader is introduced in test
> > >> case. If
> > >> NIO
> > >> > is not added in mf file, you'll see compile error in eclipse.
> > >>
> > >> Well, it is not a problem to commit this. But, WHY NIO? I thought
> > >> java.io.Reader is a part of luni module. Am I wrong?
> > >
> > > No, you're not wrong. But java.nio.CharBuffer is involved in
> > > java.io.Reader.
> > > That's why I added nio in sql manifset. You can see the compile error in
> > > Eclipse without nio dependency. Or any other way to solve this problem?
> >
> > You just need to list the immediate dependencies -- not the transitive
> > closure.
> >
> > Any dependencies that are only required in the tests should be flagged
> > as "resolution:=optional", since we package the manifest, but not the
> > tests, into the deployment JAR.
>
>
> Agreed. Shall I upload a new patch? Or will committer commit the patch with
> modification?


-- 
Alexei Zakharov,
Intel ESSD

Mime
View raw message