harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Hindess <mark.hind...@googlemail.com>
Subject Re: [jira] Need committers help in Swing/AWT area
Date Sat, 13 Jan 2007 21:10:57 GMT

On 12 January 2007 at 10:30, "Mikhail Markov"
<mikhail.a.markov@gmail.com> wrote:
> Hi, all!
> I've noticed that we have about 100 unresolved Swing/AWT JIRA with patches
> (more that 2/3 of the overall JIRA number in classlib component with
> patches).
> A lot of them related with rather simple issues like NPE, wrong Exceptions
> throwing order etc. and thus could be relatively easy integrated.
>  Resolving this JIRA will significantly improve the situation with JIRA in
> classlib.

> Also patches become outdated (see, for example
> 1603<http://issues.apache.org/jira/browse/HARMONY-1603>),
> so timely integration will help earier resolve the issues.

I took a quick look at this JIRA.  The patches apply correctly using GNU
patch and the --fuzz=3 (default is 2).  Except one hunk in the test file
which is just a trivial rename of a test that already seems to have been
renamed something else.

Increasing the fuzz factor just allows patch to ignore an extra line of
context when attempting to find an offset for the patch.  Of course,
this can be problematic but patch reports the fuzz factor used in making
any changes so you can tell that you need to check them carefully.

I've commented in the JIRA but I thought others might benefit from
knowing about this.

> Could committers, please, help to resolve these JIRAs more quickly?

I've taken a look at a few - resolved most and commented on a couple
that have issues[0].  Alexey seems to be doing some too.  (Thanks!)

It would make life easier if the patches were against the correct -
top-level or modules/<name> - directories and/or if the tests followed
the project conventions for letting junit handle exceptions and not
being verbose.[1]

That said, I appreciate the contributions and I'm not rejecting any of
them for such trivial issues.  Thanks everyone.


[0] I even wrote an evil Perl script to do "svn ci" and resolve the JIRA.
[1] I appreciate that some may predate the discussions of these 

View raw message