Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 3278 invoked from network); 14 Dec 2006 12:20:35 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 14 Dec 2006 12:20:35 -0000 Received: (qmail 67742 invoked by uid 500); 14 Dec 2006 12:20:40 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 67523 invoked by uid 500); 14 Dec 2006 12:20:40 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 67508 invoked by uid 99); 14 Dec 2006 12:20:40 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Dec 2006 04:20:40 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of alexey.a.petrenko@gmail.com designates 66.249.92.169 as permitted sender) Received: from [66.249.92.169] (HELO ug-out-1314.google.com) (66.249.92.169) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Dec 2006 04:20:29 -0800 Received: by ug-out-1314.google.com with SMTP id z36so402257uge for ; Thu, 14 Dec 2006 04:20:08 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=mwOBIVrSmiEVNvNgzdFGZZPNqSlmJZHKhL3qwCX3TtsT/WsfBYuwtjuKV/DoK1Ot4is9X6pH5vKsCv/1ms+hdhaqqdfV/bjIzTtQrkfyJYA8mgfpL68T/JPr5oct/iamwKbE2NpgoF1EQinCIwfmRHEWjxrFyacZ3int9sSYoEg= Received: by 10.78.128.11 with SMTP id a11mr655520hud.1166098807761; Thu, 14 Dec 2006 04:20:07 -0800 (PST) Received: by 10.78.107.10 with HTTP; Thu, 14 Dec 2006 04:20:07 -0800 (PST) Message-ID: Date: Thu, 14 Dec 2006 15:20:07 +0300 From: "Alexey Petrenko" To: dev@harmony.apache.org Subject: Re: [classlib] _WIN32_WINNT macro redefinition In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: X-Virus-Checked: Checked by ClamAV on apache.org I can not reproduce the build failure on two different Windows boxes. BTW, CC does not report such issue too. What compiler do you use? MSVC 2003? SY, Alexey 2006/12/14, Ivan Zvolsky : > Yes, I do. > I see this error message every time i'm trying to build classlib, > approximately since revision 486243. > > On 12/14/06, Alexey Petrenko wrote: > > > > Do you see this error message every time? > > > > SY, Alexey > > > > 2006/12/14, Ivan Zvolsky : > > > Hi all, > > > > > > Just wanted to share some experience in building classlib on Windows in > > my > > > very first mailing list post. The thing is that some recent commits into > > > classlb made it vulnerable to "external" setting of _WIN32_WINNT macro. > > > > > > Here is what I mean: win32.mak from Platform SDK (which is being > > !included > > > in classlib's makefiles) appends definition of the _WIN32_WINNT macro to > > the > > > $(cflags) variable. The value of the macro depends on the version of SDK > > > installed. And this may lead to the error while building classlib: > > > > > > <...skipped...> > > > [exec] cl -c -DCRTAPI1=_cdecl -DCRTAPI2=_cdecl -nologo -GS - > > > FIsehmap.h -GS -D_X86_=1 -DWIN32 -D_WIN32 -W3 -D_WINNT > > > -D_WIN32_WINNT=0x0501 -D_WIN32_IE=0x0500 -DWINVER=0x0501 -Zi -WX -GF -Gs > > -MD > > > -Zm400 -D_DLL -D_MT -D_WINSOCKAPI_ > > > > > /IC:\lab_drlbuild\combined_icl_d\CVS_20061213_0002_H\classlib\trunk\deploy\include > > > > > /IC:\lab_drlbuild\combined_icl_d\CVS_20061213_0002_H\classlib\trunk\deploy\jdk\include > > > /I. /I..\shared\ -Fo..\shared\hythread.obj ..\shared\hythread.c > > > [exec] hythread.c > > > [exec] thrdsup.h(64) : error C2220: warning treated as error - no > > > object file generated > > > [exec] thrdsup.h(64) : warning C4005: '_WIN32_WINNT' : macro > > > redefinition > > > [exec] NMAKE : fatal error U1077: 'cl' : return code '0x2' > > > [exec] command-line arguments : see previous definition of > > > '_WIN32_WINNT' > > > [exec] Stop. > > > > > > You see, my version of win32.mak from Platform SDK set the marco to > > > '0x0501', which is not the same in some .h file. > > > > > > I believe this should be fixed somehow :-) > > > > > > best regards, > > > Ivan > > > > > > > > > >