Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (herse.apache.org: domain of xiaofeng.li@gmail.com
 designates 66.249.92.171 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=rJcqnsXWiQCvsabxCN1SAo4puE/4sD+e59WP06pSv/XHOIbqk65razyMW6wr6hsmqklny3my6RGQWeHGdZuCJSoNWFqCbjJT/HuGnz+FIeIbBd1nLbMgkCSSg9ro0Loe92fmOrqQ5imWi5OxKLlKwC7J5dLHdak6H0XD+IIqdC4=
Message-ID: <9623c9a50612102342q1505e6e5veaf0a9a3de311b07@mail.gmail.com>
Date: Mon, 11 Dec 2006 15:42:18 +0800
From: "Xiao-Feng Li" <xiaofeng.li@gmail.com>
To: dev@harmony.apache.org
Subject: Re: [DRLVM][GCv5] patch for new LOS collector and finalizer/weakref
 support
In-Reply-To: <12385bbd0612101606p21e7b948s4b00411cfe669d3f@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <9623c9a50612091947l5d19557fhb85d60632160aed8@mail.gmail.com>
	 <12385bbd0612101606p21e7b948s4b00411cfe669d3f@mail.gmail.com>

Ivan, thanks for your quick review. Your two questions are good.
Basically the patches are for GCv5 only since we don't want to impact
any existing Harmony functionalities when GCv5 is not on. :-) At least
we want to control the impact to be minimal at the moment until we
have enough confidence. And yes, I agree with you that the coding
style should be improved, and actually that's in our plan. We'd like
to evolve the code base and probably with contributions from other
participants. The patches are supposed to be a start for further
improvements.

Thanks,
xiaofeng

On 12/11/06, Ivan Volosyuk <ivan.volosyuk@gmail.com> wrote:
> One more question. I have taken a quick glance on implementation. I
> see, some code duplication in process_weak_references,
> process_soft_references, process_phantom_references... Is this it? Why
> not create a more general function which will deal with all of the
> reference types?
> --
> Ivan
>
> On 12/10/06, Xiao-Feng Li <xiaofeng.li@gmail.com> wrote:
> > Hi, two GCv5 patches were submitted, one for GCv5 LOS collector
> > developed by Ji Qi, the other for finalizer and weak reference support
> > developed by LiGang Wang. Both patches are only for GCv5, having no
> > impact on other parts. They are tested on Windows and Linux 32bit.
> > Harmony committer please helps to integrate them into SVN at early
> > convenience.
> >
> > They are at:
> > https://issues.apache.org/jira/browse/HARMONY-2509
> > https://issues.apache.org/jira/browse/HARMONY-2560
> >
> > In order to save committer's time, the patches are built in a way that
> > the second one 2560 is based on 2509. So they can be patched in order
> > and then committed at once.
> >
> > Thanks,
> > xiaofeng
> >
>
>
> --
> Ivan
> Intel Enterprise Solutions Software Division
>