Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: neutral (herse.apache.org: 216.86.168.178 is neither permitted
 nor denied by domain of geir@pobox.com)
Message-ID: <4586943C.4030807@pobox.com>
Date: Mon, 18 Dec 2006 08:14:36 -0500
From: "Geir Magnusson Jr." <geir@pobox.com>
Reply-To: geir@pobox.com
User-Agent: Thunderbird 1.5.0.8 (Macintosh/20061025)
MIME-Version: 1.0
To: dev@harmony.apache.org
Subject: Re: [jdktools] Building jdktools and JPDA component
References: <b6cb498e0612080811j4fffe20cle7b326810d55500f@mail.gmail.com>
	 <45799D56.4060907@pobox.com>
 <b6cb498e0612150953y5bec9cbcp5718710cdf716d87@mail.gmail.com>
In-Reply-To: <b6cb498e0612150953y5bec9cbcp5718710cdf716d87@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit


Ivan Popov wrote:
>> We already discussed that, I believe.  We'll replace the Classlib files
>> w/ the DRLVM files and just go with those
> 
> Since nobody objects, could you please replace jni and jvmti headers
> in classlib/luni module with DRLVM ones? It's still not possible to
> build jdktools component because of broken jvmti.h in classlib.

I don't understand this.  The jdktools should be pulling it out of drlvm 
  (for now), so there should be no trouble building

> 
> This requires removing jni.h/jniport.h and jvmti.h files from
> 
>  working_classlib/modules/luni/src/main/native/include
> 
> and copying there files jni.h/jni_types.h and jvmti.h/jvmti_types.h from
> 
>  working_vm/vm/include
> 
> I've also added to HARMONY-2180 patch for classlib build
> 'deploy_new_jni_jvmti_headers_from_classlib_luni_module.patch' to
> deploy new header files to
> 
>  working_classlib/deploy/jdk/include
> 
> while building classlib.
> 
> I've checked this patch after moving files and this works well for me.
> I was able to build jdktools with federated build.

I don't understand.  We've been able to build jdktools w/ federated 
build for a while now...

geir

> 
> Thanks.
> Ivan
> 
> On 12/8/06, Geir Magnusson Jr. <geir@pobox.com> wrote:
>>
>>
>> Ivan Popov wrote:
>> > I've tried to build jdktools with the latest changes in its build
>> > system. On Linux build works well, but on Windows it fails mostly
>> > because of lack of makefiles for JPDA module.
>>
>> Yep, was still working on that.
>>
>> >
>> > I've created missed makefiles for JPDA module, prepared patches and
>> > added them to HARMONY-2180. With these patches jdktools component is
>> > built successfully on both Windows and Linux. It can be built on top
>> > on working_classlib as well as referencing to existing HDK by using
>> > hy.hdk property. These makefiles are simple enough, but I'd like them
>> > to be committed to svn, so we can build jdktools on both platforms and
>> > can improve the overall build later.
>>
>> Yep.  Thanks
>>
>> >
>> > The only problem is that the required jvmti.h file is missed in HDK
>> > and its classlib copy (provided in
>> > working_classlib/deploy/jdk/include) does not support C++. I've just
>> > manually replaced jvmti.h and jni.h/jniport.h in working_classlib with
>> > jvmti.h/jvmti_types.h and jni.h/jni_types.h from DRLVM and was able to
>> > build jdktools.
>> >
>> > We have to agree on which copies of jni.h/jvmti.h should be shared
>> > between Harmony components and where they should be located. One of
>> > possible solution is to move these files to the top-level component
>> > common_resources.
>>
>> We already discussed that, I believe.  We'll replace the Classlib files
>> w/ the DRLVM files and just go with those
>>
>> >
>> > One more problem with building jdktools is that 'ant clean' fails
>> > reporting the following file was not deleted:
>> >
>> >  
>> working_jdktools\build\classes\org\apache\harmony\tools\ijh\anttask\Adapter.class 
>>
>> >
>> >
>> > However, second attempt to run 'ant clean' succeeds. I did not check
>> > what's the problem with deleting this file.
>> >
>> > Thanks.
>> > Ivan
>>