Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (herse.apache.org: domain of t.p.ellison@gmail.com
 designates 66.249.92.173 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:user-agent:mime-version:to:subject:references:in-reply-to:x-enigmail-version:content-type:content-transfer-encoding;
        b=XmgNdhb6q7g6wwFczk+o3Vi89lM8PZ8/UnQEbW6KLEENSVjXd9eFUdif3uMLBxlmLqcSF2Jra2C1LwpYBJpnBbYOd5afm5A9m8Yr96P1ux2Zblppv3NG9d9fmUbDJFmIsDP9GddZefCXDQ+IFDy4Ej9B0j2qWoY7bJV3v1k1+jY=
Message-ID: <457FC8C7.2090102@gmail.com>
Date: Wed, 13 Dec 2006 09:32:55 +0000
From: Tim Ellison <t.p.ellison@gmail.com>
User-Agent: Thunderbird 1.5.0.8 (Windows/20061025)
MIME-Version: 1.0
To: dev@harmony.apache.org
Subject: Re: [drlvm][em64t] drlvm broken on em64t?
References: <457EC663.5040209@pobox.com>
 <457EE270.2040602@pobox.com>	 <elmpad$tof$1@sea.gmane.org>
 <457EEC45.20308@pobox.com>	 <eln5bt$ee3$1@sea.gmane.org>
 <457F1E88.7050807@pobox.com>
	 <c3755b3a0612121334w3d56cebbk66b34dc0b3189506@mail.gmail.com>
 <c3755b3a0612121337h17b26246l383304578a3f14ec@mail.gmail.com>
 <eln8kp$ph5$1@sea.gmane.org> <457F2FCF.2040905@pobox.com>
 <elnc0q$6k4$1@sea.gmane.org> <457F350A.5090104@pobox.com>
In-Reply-To: <457F350A.5090104@pobox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Geir Magnusson Jr. wrote:
> Right - the thing I was asking if the behavior of GetSystemProperty()
> changed.
> 
> Looking at Ollie's change in r486100, he seems to think that it's not an
> error to not have the property set, but our impl of it does.
> 
> That's the issue I'm trying to get to - does the API of
> GetSystemProperty() specify that it returns an error code if the
> property isn't set?
> 
> If so, then Ollie's code is wrong.  If not, then it's either that the
> API is ambiguous (Ollie's assumption wasn't unreasonable) or our impl of
> GetSystemProperty() is wrong.


I agree that the API needs further definition, so I propose the
following clarification:

Index: modules/luni/src/main/native/include/shared/vmi.h
===================================================================
--- modules/luni/src/main/native/include/shared/vmi.h	(revision 486224)
+++ modules/luni/src/main/native/include/shared/vmi.h	(working copy)
@@ -220,7 +220,7 @@

  /**
   * @fn VMInterfaceFunctions_::GetSystemProperty(VMInterface * vmi,
char *key, char **valuePtr)
-  * Retrieve the value of a VM system property.
+  * Retrieve the value of a VM system property. If the property is not
set returns NULL.
   *
   * @note The returned string is owned by the VM, and should not be freed.
   */

Regards,
Tim