Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 15582 invoked from network); 4 Dec 2006 13:32:37 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 4 Dec 2006 13:32:37 -0000 Received: (qmail 68509 invoked by uid 500); 4 Dec 2006 13:32:43 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 68420 invoked by uid 500); 4 Dec 2006 13:32:43 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 68410 invoked by uid 99); 4 Dec 2006 13:32:43 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Dec 2006 05:32:43 -0800 X-ASF-Spam-Status: No, hits=1.4 required=10.0 tests=SPF_HELO_PASS,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (herse.apache.org: 216.86.168.178 is neither permitted nor denied by domain of geir@pobox.com) Received: from [216.86.168.178] (HELO mxout-03.mxes.net) (216.86.168.178) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Dec 2006 05:32:30 -0800 Received: from [192.168.1.104] (unknown [67.86.14.213]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.mxes.net (Postfix) with ESMTP id 4F7F651926 for ; Mon, 4 Dec 2006 08:32:05 -0500 (EST) Message-ID: <45742354.20203@pobox.com> Date: Mon, 04 Dec 2006 08:32:04 -0500 From: "Geir Magnusson Jr." Reply-To: geir@pobox.com User-Agent: Thunderbird 1.5.0.8 (Macintosh/20061025) MIME-Version: 1.0 To: dev@harmony.apache.org Subject: Re: svn commit: r480871 - in /harmony/enhanced/classlib/trunk/modules/luni/src: main/java/java/lang/ProcessBuilder.java main/java/org/apache/harmony/luni/platform/Environment.java test/java/org/apache/harmony/luni/tests/java/lang/SystemTest.java References: <20061130081959.0B5381A9846@eris.apache.org> <4570467F.5010207@pobox.com> <211709bc0612032250u15c98f97k6a4f103056c9476@mail.gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Alexey Varlamov wrote: > 2006/12/4, Tony Wu : >> This class will never be serialized. I think the meanless variable >> here is created to avoid compiler warining. > > How about using @SupressWarnings("serial")? It is more readable IMO. Thank you. I didn't know what to suggest, but a magic value was misleading w/o a comment... geir > >> >> On 12/1/06, Geir Magnusson Jr. wrote: >> > >> > >> > liangyx@apache.org wrote: >> > > Author: liangyx >> > > Date: Thu Nov 30 00:19:55 2006 >> > > New Revision: 480871 >> > > >> > > URL: http://svn.apache.org/viewvc?view=rev&rev=480871 >> > > Log: >> > > Apply patch for HARMONY-2356 ([classlib][luni]The Map from >> System.getEnv should throw NullPointerException while get(null) and is >> not modifiable.) >> > > >> > > Modified: >> > > >> harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/lang/ProcessBuilder.java >> >> > > >> harmony/enhanced/classlib/trunk/modules/luni/src/main/java/org/apache/harmony/luni/platform/Environment.java >> >> > > >> harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/SystemTest.java >> >> > > >> > >> > > + >> > > + public static class EnvironmentMap extends HashMap> String> { >> > > + >> > > + private static final long serialVersionUID = 1L; >> > > + >> > > + public EnvironmentMap() { >> > > + super(); >> > > + } >> > > + >> > > + public EnvironmentMap(Map map) { >> > > + super(map); >> > > + } >> > > + >> > > + public boolean containsKey(Object key) { >> > > + checkParam(key); >> > > + return super.containsKey(key); >> > > + } >> > >> > >> > >> > I'm curious - why set the ServialVersionUID to 1? >> > >> > geir >> > >> >> >> -- >> Tony Wu >> China Software Development Lab, IBM >>