harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Varlamov" <alexey.v.varla...@gmail.com>
Subject Re: [general] things are broken?
Date Thu, 14 Dec 2006 10:40:49 GMT
2006/12/14, Geir Magnusson Jr. <geir@pobox.com>:
> File a JIRA to revert a mod?  Only if there's something to be fixed
> later that you think you'll forget about.
Nope, to leave a reminder to IBM folks - in case they wanna have it
fixed in j9 too.

>
> If you plan to manage this until fixed, then no.
>
> geir
>
>
> Alexey Varlamov wrote:
> > Hmm. This has nothing to do with VMI - part of my latest
> > SecurityManagerTest modification leads to crash on j9@WinXP. This one:
> >
> > Index:
> > modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/SecurityManagerTest.java
> >
> > ===================================================================
> > ---
> > modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/SecurityManagerTest.java
> > (revision
> > 487033)
> > +++
> > modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/SecurityManagerTest.java
> > (working
> > copy)
> > @@ -167,18 +166,12 @@
> >     private static class checkPermissionLjava_security_PermissionTesting {
> >         public static void main(String[] args) {
> >             MutableSecurityManager sm = new MutableSecurityManager();
> > -            sm.addPermission(MutableSecurityManager.SET_SECURITY_MANAGER);
> >             System.setSecurityManager(sm);
> >             try {
> > -                try {
> > -                    System.getSecurityManager().checkPermission(
> > -                            new RuntimePermission("createClassLoader"));
> > -                    fail("This should throw a SecurityException");
> > -                } catch (SecurityException e) {
> > -                }
> > -            } finally {
> > -                System.setSecurityManager(null);
> > -            }
> > +                System.getSecurityManager().checkPermission(
> > +                    new RuntimePermission("createClassLoader"));
> > +                fail("This should throw a SecurityException");
> > +            } catch (SecurityException ok) {}
> >         }
> >     }
> >
> > Basically this is a bug of j9 (windows version), installed security
> > manager prevents gracefull VM shutdown. DRLVM on Windows and Linux and
> > J9 on Linux work fine with this.
> > I'm going to revert this mod, do I need to file a JIRA?
> >
> > --
> > Alexey
> >
> >
> > 2006/12/14, Alexey Varlamov <alexey.v.varlamov@gmail.com>:
> >> Reproduced the crash on
> >> org.apache.harmony.luni.tests.java.lang.SecurityManagerTest
> >> Investigating...
> >>
> >> 2006/12/14, Tim Ellison <t.p.ellison@gmail.com>:
> >> > Geir Magnusson Jr. wrote:
> >> > > We seem to be very broken right now.  Can anyone verify classlib
> >> tests
> >> > > passing using either J9 or DRLVM?
> >> >
> >> > LUNI tests now failing for me on IBM VME / Win XP
> >> >
> >> > I get a seg fault during shutdown of the port library in the launcher
> >> > code -- hyportLibrary.port_shutdown_library (&hyportLibrary);
> >> >
> >> > last good run I see is at r487110.
> >> >
> >> > Regards,
> >> > Tim
> >> >
> >>
>

Mime
View raw message