harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Evgueni Brevnov" <evgueni.brev...@gmail.com>
Subject Re: [dlvm][classlib] Re: hythr library problem... easy fix?
Date Wed, 06 Dec 2006 07:05:04 GMT
Ok, here is the fix https://issues.apache.org/jira/browse/HARMONY-2483

Evgueni

On 12/5/06, Alexey Petrenko <alexey.a.petrenko@gmail.com> wrote:
> 2006/12/5, Evgueni Brevnov <evgueni.brevnov@gmail.com>:
> > On 12/5/06, Alexey Petrenko <alexey.a.petrenko@gmail.com> wrote:
> > > 2006/12/5, Evgueni Brevnov <evgueni.brevnov@gmail.com>:
> > > > On 12/5/06, Alexey Petrenko <alexey.a.petrenko@gmail.com> wrote:
> > > > > 2006/12/5, Evgueni Brevnov <evgueni.brevnov@gmail.com>:
> > > > > > Here is my understanding....
> > > > > >
> > > > > > By looking at classlib's spec and impl for hythread_detach shows
that
> > > > > > it is pretty valid to detach any attached thread (not current
thread
> > > > > > only). So classlib's implementation does ignore the request
to detach
> > > > > > the thread as it suggested in the patch.
> > > >
> > > > Upss... missprint here....should be... "So classlib's implementation
> > > > DOESN'T ignore the request to detach the thread as it suggested in the
> > > > patch."
> > > So you suggest to just remove this assert?
> >
> > No. We can't just remove an assertion. We need to either provide
> > proper implementation in case the specified thread differs from the
> > current or fix the caller's side (and spec actually) to call
> > hythread_detach from current thread only.
> Ulternate fix is welcome :)
>
> SY, Alexey
>

Mime
View raw message