harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiao-Feng Li" <xiaofeng...@gmail.com>
Subject Re: [DRLVM][GCv5] patch for new LOS collector and finalizer/weakref support
Date Sat, 16 Dec 2006 01:33:44 GMT
Pavel, please see my message in another threads. Thanks, -xiaofeng

On 12/15/06, Pavel Pervov <pmcfirst@gmail.com> wrote:
> Xiao Feng,
>
> Putting it the other way: what is wrong with DRLVM implementation, which
> required you to invent your own?
>
> Thanks,
>     Pavel.
>
>
> On 12/15/06, Pavel Pervov <pmcfirst@gmail.com> wrote:
> >
> > Xiao Feng,
> >
> > I didn't find any reason for replacing finalization and weak reference
> > implementation in your answer beside the fact that what you did is for GCv5
> > only.
> > Could you please, clarify it?
> >
> > Thanks,
> >      Pavel.
> >
> >  On 12/11/06, Xiao-Feng Li <xiaofeng.li@gmail.com> wrote:
> > >
> > > Ivan, thanks for your quick review. Your two questions are good.
> > > Basically the patches are for GCv5 only since we don't want to impact
> > > any existing Harmony functionalities when GCv5 is not on. :-) At least
> > > we want to control the impact to be minimal at the moment until we
> > > have enough confidence. And yes, I agree with you that the coding
> > > style should be improved, and actually that's in our plan. We'd like
> > > to evolve the code base and probably with contributions from other
> > > participants. The patches are supposed to be a start for further
> > > improvements.
> > >
> > > Thanks,
> > > xiaofeng
> > >
> > > On 12/11/06, Ivan Volosyuk < ivan.volosyuk@gmail.com> wrote:
> > > > One more question. I have taken a quick glance on implementation. I
> > > > see, some code duplication in process_weak_references,
> > > > process_soft_references, process_phantom_references... Is this it? Why
> > > > not create a more general function which will deal with all of the
> > > > reference types?
> > > > --
> > > > Ivan
> > > >
> > > > On 12/10/06, Xiao-Feng Li < xiaofeng.li@gmail.com> wrote:
> > > > > Hi, two GCv5 patches were submitted, one for GCv5 LOS collector
> > > > > developed by Ji Qi, the other for finalizer and weak reference
> > > support
> > > > > developed by LiGang Wang. Both patches are only for GCv5, having
no
> > > > > impact on other parts. They are tested on Windows and Linux 32bit.
> > > > > Harmony committer please helps to integrate them into SVN at early
> > > > > convenience.
> > > > >
> > > > > They are at:
> > > > > https://issues.apache.org/jira/browse/HARMONY-2509
> > > > > https://issues.apache.org/jira/browse/HARMONY-2560
> > > > >
> > > > > In order to save committer's time, the patches are built in a way
> > > that
> > > > > the second one 2560 is based on 2509. So they can be patched in
> > > order
> > > > > and then committed at once.
> > > > >
> > > > > Thanks,
> > > > > xiaofeng
> > > > >
> > > >
> > > >
> > > > --
> > > > Ivan
> > > > Intel Enterprise Solutions Software Division
> > > >
> > >
> >
> >
> >
> > --
> > Pavel Pervov,
> > Intel Enterprise Solutions Software Division
> >
>
>
>
> --
> Pavel Pervov,
> Intel Enterprise Solutions Software Division
>
>

Mime
View raw message