harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geir Magnusson Jr." <g...@pobox.com>
Subject Re: svn commit: r480871 - in /harmony/enhanced/classlib/trunk/modules/luni/src: main/java/java/lang/ProcessBuilder.java main/java/org/apache/harmony/luni/platform/Environment.java test/java/org/apache/harmony/luni/tests/java/lang/SystemTest.java
Date Mon, 04 Dec 2006 13:32:04 GMT


Alexey Varlamov wrote:
> 2006/12/4, Tony Wu <wuyuehao@gmail.com>:
>> This class will never be serialized. I think the meanless variable
>> here is created to avoid compiler warining.
> 
> How about using @SupressWarnings("serial")? It is more readable IMO.

Thank you.  I didn't know what to suggest, but a magic value was 
misleading w/o a comment...

geir

> 
>>
>> On 12/1/06, Geir Magnusson Jr. <geir@pobox.com> wrote:
>> >
>> >
>> > liangyx@apache.org wrote:
>> > > Author: liangyx
>> > > Date: Thu Nov 30 00:19:55 2006
>> > > New Revision: 480871
>> > >
>> > > URL: http://svn.apache.org/viewvc?view=rev&rev=480871
>> > > Log:
>> > > Apply patch for HARMONY-2356 ([classlib][luni]The Map from 
>> System.getEnv should throw NullPointerException while get(null) and is 
>> not modifiable.)
>> > >
>> > > Modified:
>> > >     
>> harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/lang/ProcessBuilder.java

>>
>> > >     
>> harmony/enhanced/classlib/trunk/modules/luni/src/main/java/org/apache/harmony/luni/platform/Environment.java

>>
>> > >     
>> harmony/enhanced/classlib/trunk/modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/SystemTest.java

>>
>> > >
>> >
>> > > +
>> > > +    public static class EnvironmentMap extends HashMap<String, 
>> String> {
>> > > +
>> > > +        private static final long serialVersionUID = 1L;
>> > > +
>> > > +        public EnvironmentMap() {
>> > > +            super();
>> > > +        }
>> > > +
>> > > +        public EnvironmentMap(Map<String, String> map) {
>> > > +            super(map);
>> > > +        }
>> > > +
>> > > +        public boolean containsKey(Object key) {
>> > > +            checkParam(key);
>> > > +            return super.containsKey(key);
>> > > +        }
>> >
>> >
>> >
>> > I'm curious - why set the ServialVersionUID to 1?
>> >
>> > geir
>> >
>>
>>
>> -- 
>> Tony Wu
>> China Software Development Lab, IBM
>>

Mime
View raw message