harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geir Magnusson Jr." <g...@pobox.com>
Subject Re: [classlib] jvmti.h in classlib
Date Fri, 01 Dec 2006 15:44:04 GMT


Tim Ellison wrote:
> Ivan Popov wrote:
>> Header file jvmti.h (as well as deprecated jvmpi.h) from classlib does
>> not support C++ sources, only plain C ones. This is why JDWP agent
>> code, wtitten in C++, cannot use jvmti.h from classlib.
>>
>> DRLVM copies of jni.h and jvmti.h correctly support both C and C++
>> sources, so we could use them and get rid of classlib ones.
> 
> Its trivial to add the C++ support, so it doesn't matter which ones are
> retained -- I agree a single copy of these include files is fine.
> 
> I can't think of an easy way off the top of my head to check for
> equivalence between them ... any better idea than tediously comparing?
> 
> Obviously we need a copy of them available to compile the classlib
> native code, so any objections to keeping them there and DRLVM picking
> them up from the HDK?  Other ideas?

No objection, but I just want to fix this and move on.

One solution is for me to just drop the stuff in from DRLVM and replace 
the classlib ones, and then if things work, commit.

I think we can nip and tuck going forward if need be, because, as you 
note it will be hard to compare.

geir


Mime
View raw message