harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexei Zakharov" <alexei.zakha...@gmail.com>
Subject Re: [classlib] new dependency (was: Re: [testing][crash handling] it will nice to add *any* crash handling to build system)
Date Fri, 15 Dec 2006 13:47:59 GMT
> Is there any way to collect tests out/err within the build (e.g. via
> ant loggers)?  Then we could include these into TEST-crashed.xml, which
> would easy investigation significantly.

Agree, this also might be useful. I am not sure that TEST-crashed.xml
is the right place for such logs since *crashed* test does not produce
any log. Anyway, IMHO this is a separate issue and we could do this as
a next step.

Thanks,

2006/12/15, Alexey Varlamov <alexey.v.varlamov@gmail.com>:
> 2006/12/12, Vladimir Ivanov <ivavladimir@gmail.com>:
> > On 12/12/06, Mark Hindess <mark.hindess@googlemail.com> wrote:
> > >
> > >
> > > I can't see how to do exactly what you want, but perhaps it would be
> > > sufficient to use the echo task to create a "TEST-crashed.xml" file with
> > > the list of tests (pathconvert with dirsep="${line.separator}") as the
> > > error message?
> >
> >
> >
> > I think it will be enough. In general, error and output streams are missed
> > for these tests so we can have one failed test with a list of tests to
> > investigate.
> Is there any way to collect tests out/err within the build (e.g. via
> ant loggers)? Then we could include these into TEST-crashed.xml, which
> would easy investigation significantly.
>
> >
> >  Thanks, Vladimir
> >
> >
> >
> > > HTH,
> > > Mark.
> > >
> > > > Thanks!
> > > >
> > > > 2006/12/11, Vladimir Ivanov <ivavladimir@gmail.com>:
> > > > > Agree, this approach is better than additional dependency.
> > > > >
> > > > > Alexei, please, throw out my jira and use this code.
> > > > >
> > > > >  Thanks, Vladimir
> > > > >
> > > > >
> > > > > On 12/10/06, Mark Hindess <mark.hindess@googlemail.com> wrote:
> > > > > >
> > > > > >
> > > > > > Please don't add this dependency.  We should use something like:
> > > > > >
> > > > > > <project name="test">
> > > > > > <target name="check-for-empty" depends="-check-for-empty,
> > > fail-if-empty"
> > > > > > />
> > > > > > <target name="-check-for-empty">
> > > > > >    <fileset id="empty.test.reports" dir="test_report">
> > > > > >      <patternset>
> > > > > >        <include name="TEST-*.xml"/>
> > > > > >      </patternset>
> > > > > >      <size value="0" when="equal"/>
> > > > > >    </fileset>
> > > > > >    <pathconvert refid="empty.test.reports" property="crashed.tests"
> > > />
> > > > > >    <condition property="tests.crashed">
> > > > > >      <not>
> > > > > >        <equals arg1="" arg2="${crashed.tests}" />
> > > > > >      </not>
> > > > > >    </condition>
> > > > > > </target>
> > > > > > <target name="fail-if-empty" if="${crashed.tests}">
> > > > > >    <fail>Crashed tests: "${crashed.tests}"</fail>
> > > > > > </target>
> > > > > > </project>
> > > > > >
> > > > > >
> > > > > > -Mark.
> > > > > >
> > > > > > On 9 December 2006 at 23:29, "Alexei Zakharov" <
> > > alexei.zakharov@gmail.com
> > > > >
> > > > > > wrote:
> > > > > > > All,
> > > > > > >
> > > > > > > I am going to commit changes for HARMONY-2349 ([classlib][testing]
> > > > > > > "detect crashes by the empty report files") now. However,
I've
> > > > > > > realized that in order to do this I need to introduce a
new
> > > dependency
> > > > > > > to our list of classlib dependencies - the ant-contrib
package.
> > > > > > > Personally I don't see any harm in this. It is quite nice
package,
> > > we
> > > > > > > can also use it for organizing iterative test runs for
example.
> > > > > > > Moreover, there is no need to force users to copy it to
> > > ANT_HOME/lib
> > > > > > > or wherever since ant's taskdef target is capable to load
JAR's
> > > > > > > dynamically. BTW, DRLVM build has been using ant-contrib
from the
> > > > > > > beginning.
> > > > > > >
> > > > > > > But I'd like to hear from others. Is ant-contrib ok with
everyone?
> > > > > > >
> > > > > > > Thanks,
> > > > > > >
> > > > > > > 2006/12/8, Vladimir Ivanov <ivavladimir@gmail.com>:
> > > > > > > > The last CC notification for 'Linux SUSE 9 gcc debug:
> > > classlib  over
> > > > > > ibmvm'
> > > > > > > > has failed status due to "There were test errors"
but on the
> > > next lin
> > > > e
> > > > > > it
> > > > > > > > told "All Tests Passed".
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > Note, it happened due to test crash:
> > > > > > > >
> > > > > > > > [Fatal Error] :-1:-1: Premature end of file.
> > > > > > > >
> > > > > > > > The file
> > > > > > > >
> > > /export/viv/trunk/cc/projects/classlib/trunk/build/test_report/TEST-
> > > > > > > >
> > > org.apache.harmony.security.tests.java.security.IdentityScope2Test.xm
> > > > lis
> > > > > > > > not a valid XML document. It is possibly corrupted.
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > This crash change the build status to 'FAILED' but
no report
> > > file wer
> > > > e
> > > > > > > > generated so junit- reporter miss this crash.
>


-- 
Alexei Zakharov,
Intel ESSD

Mime
View raw message