Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Received-SPF: pass (herse.apache.org: domain of alexey.v.varlamov@gmail.com
 designates 66.249.82.230 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=qsXE5nYiq6mjIWhi14KrORPs5gSp6KvUWGqDgcQAYwh8zf3VDQAfZII3W1i8Afo5sOG/dtoUkkgkko7mxGbbeHwQW29bFEaHOTSqANWdmBkP3whw6DQ+3k87qLW+p0AGJlqaZk1Y+NbKZS6WK2N0pgZ1v6hAn5wBXFt0OHodYN4=
Message-ID: <f944d83d0611152153t37c1214dw90826fd87b60eb31@mail.gmail.com>
Date: Thu, 16 Nov 2006 11:53:44 +0600
From: "Alexey Varlamov" <alexey.v.varlamov@gmail.com>
To: harmony-dev@incubator.apache.org
Subject: Re: [drlvm] New regression: java.lang.ClassGenericsTest4
In-Reply-To: <ejfllm$bqo$1@sea.gmane.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <200611150401.28037.gshimansky@gmail.com>
	 <f944d83d0611142323n7ca6d2ai1592e0a312beb123@mail.gmail.com>
	 <f944d83d0611150038x246390f1ob32289ee4c1fff42@mail.gmail.com>
	 <ejf2o0$2bc$1@sea.gmane.org>
	 <f944d83d0611150521i4f75ba4as732428ea9c1cec8a@mail.gmail.com>
	 <f944d83d0611150531y6fe3e608vce8a4f0b8e36e860@mail.gmail.com>
	 <ejf551$asj$1@sea.gmane.org>
	 <f944d83d0611150857m56dc3666j6bdb785c484001d0@mail.gmail.com>
	 <ejfllm$bqo$1@sea.gmane.org>

2006/11/16, Gregory Shimansky <gshimansky@gmail.com>:
> Alexey Varlamov wrote:
> > Err, what I found is really trivial bug. But it took quite a few time
> > to discover - seems today was not my day :(
> >
> > Index: vm/vmcore/src/exception/exceptions_impl.cpp
> > ===============================================================
> > --- vm/vmcore/src/exception/exceptions_impl.cpp (revision 475132)
> > +++ vm/vmcore/src/exception/exceptions_impl.cpp (working copy)
> > @@ -281,7 +281,7 @@
> >
> >         if (NULL != exception->exc_cause) {
> >             tmn_suspend_disable_recursive();
> > -            jthrowable exc_cause = oh_allocate_local_handle();
> > +            exc_cause = oh_allocate_local_handle();
> >             exc_cause->object = exception->exc_cause;
> >             tmn_suspend_enable_recursive();
> >         }
>
> Cool. Could you please commit the fix?

Committed along with regression testcase at r475590.

>
> > OK, we definitely need a regression test for this.
> >
> > 2006/11/15, Gregory Shimansky <gshimansky@gmail.com>:
> >> Alexey Varlamov wrote:
> >> > 2006/11/15, Alexey Varlamov <alexey.v.varlamov@gmail.com>:
> >> >> 2006/11/15, Gregory Shimansky <gshimansky@gmail.com>:
> >> >> > Alexey Varlamov wrote:
> >> >> > > The guilty change is the following, which effectively turns on
> >> >> > > VM_LAZY_EXCEPTION support in exceptions_impl.cpp:
> >> >> >
> >> >> > Well this is a patch from HARMONY-2018 which doesn't hide the
> >> fact that
> >> >> > it enables lazy exceptions. Why shouldn't we enable them?
> >> >
> >> > Gregory,
> >> >
> >> > I've just re-read my posts and couldn't find anything critique or
> >> > offending - please don't take regressions too personal. I'm sure we
> >> > will be able to fix this one quite soon.
> >>
> >> I wasn't offended in any way. I was just thinking that you know some
> >> secret knowledge that lazy exceptions do not work and thus enabling them
> >> is wrong.
> >>
> >> --
> >> Gregory
> >>
> >>
> >
>
>
> --
> Gregory
>
>