Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: neutral (herse.apache.org: 216.86.168.178 is neither permitted
 nor denied by domain of geir@pobox.com)
Message-ID: <456E5115.80700@pobox.com>
Date: Wed, 29 Nov 2006 22:33:41 -0500
From: "Geir Magnusson Jr." <geir@pobox.com>
Reply-To: geir@pobox.com
User-Agent: Thunderbird 1.5.0.8 (Macintosh/20061025)
MIME-Version: 1.0
To: dev@harmony.apache.org
Subject: Re: [drlvm/classlib/jdktools] system property o.a.h.boot.class.path
References: <456E1959.8050408@pobox.com>
 <f944d83d0611291730r3a47b40dwa5cc35436ac91899@mail.gmail.com>
 <456E3AFF.1000001@pobox.com>
 <f944d83d0611291815n3ce63a10o63a5245ebb3cb503@mail.gmail.com>
 <456E4521.3060903@pobox.com>
 <f944d83d0611291906s5f7851f9p8c07d17466ac02cb@mail.gmail.com>
In-Reply-To: <f944d83d0611291906s5f7851f9p8c07d17466ac02cb@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit


Alexey Varlamov wrote:
> 2006/11/30, Geir Magnusson Jr. <geir@pobox.com>:
>>
>>
>> Alexey Varlamov wrote:
>> > 2006/11/30, Geir Magnusson Jr. <geir@pobox.com>:
>> >>
>> >>
>> >> Alexey Varlamov wrote:
>> >> > 2006/11/30, Geir Magnusson Jr. <geir@pobox.com>:
>> >> >> (How's that for a category in the subject line?)
>> >> >>
>> >> >> I'm working on jdktools, and was getting javac going.  We have a 
>> small
>> >> >> issue.  Currently, the wrapper code grabs the boot class path 
>> via the
>> >> >> system property
>> >> >>
>> >> >>     org.apache.harmony.boot.class.path
>> >> >>
>> >> >> This is initially set by luni, which collects all the entries in
>> >> >> bootclasspath.properties and adds them to the path.
>> >> >>
>> >> >> Now, the one thing that it doesn't do is include the kernel.jar, as
>> >> >> that's a degree of freedom for the vm which provides that jar.
>> >> >>
>> >> >> Now, in DRLVM, we take the o.a.h.b.c.p and prefix the kernel.jar,
>> >> prefix
>> >> >> and postfix -Xbootclasspath/? for a complete runtime bootclasspath,
>> >> and
>> >> >> call it
>> >> >>
>> >> >>     vm.boot.class.path
>> >> >
>> >> > Things are changing :) Since recent H-2008 commit, magics support 
>> jars
>> >> > are going to bypass this machinery and slip into boot loader 
>> directly
>> >> > via SetBCPElement().
>> >>
>> >> Bypass what machinery?
>> >
>> > Composing BCP from prefixes and postfixes, and keeping whole runtime
>> > BCP string as a property. They just add jars directly to a vector of
>> > searching elements of BootstrapClassLoader, and this is no good from
>> > my POV.
>>
>> I'm confused.  We do need to have the string, at least able to be
>> created on demand.
> Indeed - and I see no reason why treat magics differently.
> 
>> Do you believe that adding jars directly is no good?
> I prefer to have the consistent way.
> IMHO BootstrapClassLoader::SetBCPElement() should not be public, it is
> just a part of BootstrapClassLoader initialization and not intended
> for regular usage.

OH!  So you're saying that you don't like the direct injection into the 
vector, but rather would normalize it into the way it's happening now in 
BootstrapClassloader?

if so, I agree 100% - sorry about the confusion

geir