Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (herse.apache.org: domain of nbeyer@gmail.com designates
 66.249.82.238 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=RTjBtgUmJW1sbWG1yesVOzly3GFaooHYrZen1MUGldbJKy0ikDthkoQFE0qwjF6jHvrxUoGzEpgYsvGzYe6gmjVpNvuS60ypEgqsl8dZYq1R6B9fmXkNqqj2FG+AgLFToes5+3M3YpAwVfjOioUCTPE6C7txzIqMdYikqIHDlUQ=
Message-ID: <3b3f27c60611272224o10be1898k8acffeada926a412@mail.gmail.com>
Date: Tue, 28 Nov 2006 00:24:22 -0600
From: "Nathan Beyer" <nbeyer@gmail.com>
To: dev@harmony.apache.org, geir@pobox.com
Subject: Re: svn commit: r479913 - in
 /harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo:
 AbstractUndoableEditTest.java CannotRedoExceptionTest.java
 CannotUndoExceptionTest.java
In-Reply-To: <456BD41B.3080407@pobox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20061128053133.719F81A9846@eris.apache.org>
	 <456BD41B.3080407@pobox.com>

To make the tests consistent with the majority (my observation) of the
other Harmony test cases without them.

Besides that, from a pragmatic view, it's never used. The caveat to
that might be that lone hacker doing everything from the command-line
and invoking individual tests, if they have main methods, via a "java
..." command.

-Nathan

On 11/28/06, Geir Magnusson Jr. <geir@pobox.com> wrote:
> I'm game - why should the main() be removed?
>
> geir
>
> ndbeyer@apache.org wrote:
> > Author: ndbeyer
> > Date: Mon Nov 27 21:31:26 2006
> > New Revision: 479913
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=479913
> > Log:
> > Remove unnecessary and empty methods
> >
> > Modified:
> >     harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/AbstractUndoableEditTest.java
> >     harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/CannotRedoExceptionTest.java
> >     harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/CannotUndoExceptionTest.java
> >
> > Modified: harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/AbstractUndoableEditTest.java
> > URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/AbstractUndoableEditTest.java?view=diff&rev=479913&r1=479912&r2=479913
> > ==============================================================================
> > --- harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/AbstractUndoableEditTest.java (original)
> > +++ harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/AbstractUndoableEditTest.java Mon Nov 27 21:31:26 2006
> > @@ -35,10 +35,6 @@
> >
> >      private String defaultRedoName;
> >
> > -    public static void main(final String[] args) {
> > -        junit.textui.TestRunner.run(AbstractUndoableEditTest.class);
> > -    }
> > -
> >      @Override
> >      protected void setUp() throws Exception {
> >          obj = new AbstractUndoableEdit();
> >
> > Modified: harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/CannotRedoExceptionTest.java
> > URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/CannotRedoExceptionTest.java?view=diff&rev=479913&r1=479912&r2=479913
> > ==============================================================================
> > --- harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/CannotRedoExceptionTest.java (original)
> > +++ harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/CannotRedoExceptionTest.java Mon Nov 27 21:31:26 2006
> > @@ -14,25 +14,12 @@
> >   *  See the License for the specific language governing permissions and
> >   *  limitations under the License.
> >   */
> > -/**
> > - * @author Evgeniya G. Maenkova
> > - * @version $Revision$
> > - */
> > +
> >  package javax.swing.undo;
> >
> >  import junit.framework.TestCase;
> >
> >  public class CannotRedoExceptionTest extends TestCase {
> > -    @Override
> > -    protected void setUp() throws Exception {
> > -        super.setUp();
> > -    }
> > -
> > -    @Override
> > -    protected void tearDown() throws Exception {
> > -        super.tearDown();
> > -    }
> > -
> >      public void testCannotRedoException() {
> >          CannotRedoException exception = new CannotRedoException();
> >          assertNull(exception.getMessage());
> >
> > Modified: harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/CannotUndoExceptionTest.java
> > URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/CannotUndoExceptionTest.java?view=diff&rev=479913&r1=479912&r2=479913
> > ==============================================================================
> > --- harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/CannotUndoExceptionTest.java (original)
> > +++ harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/CannotUndoExceptionTest.java Mon Nov 27 21:31:26 2006
> > @@ -14,25 +14,12 @@
> >   *  See the License for the specific language governing permissions and
> >   *  limitations under the License.
> >   */
> > -/**
> > - * @author Evgeniya G. Maenkova
> > - * @version $Revision$
> > - */
> > +
> >  package javax.swing.undo;
> >
> >  import junit.framework.TestCase;
> >
> >  public class CannotUndoExceptionTest extends TestCase {
> > -    @Override
> > -    protected void setUp() throws Exception {
> > -        super.setUp();
> > -    }
> > -
> > -    @Override
> > -    protected void tearDown() throws Exception {
> > -        super.tearDown();
> > -    }
> > -
> >      public void testCannotRedoException() {
> >          CannotUndoException exception = new CannotUndoException();
> >          assertNull(exception.getMessage());
> >
> >
>