Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 25259 invoked from network); 30 Nov 2006 10:28:55 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 30 Nov 2006 10:28:55 -0000 Received: (qmail 58500 invoked by uid 500); 30 Nov 2006 10:28:57 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 58464 invoked by uid 500); 30 Nov 2006 10:28:57 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 58450 invoked by uid 99); 30 Nov 2006 10:28:57 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Nov 2006 02:28:57 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of alexei.zakharov@gmail.com designates 66.249.92.173 as permitted sender) Received: from [66.249.92.173] (HELO ug-out-1314.google.com) (66.249.92.173) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Nov 2006 02:28:46 -0800 Received: by ug-out-1314.google.com with SMTP id z36so1625880uge for ; Thu, 30 Nov 2006 02:28:25 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=XfD9pOf+kNvB2umeyGz1/rJjmAfTyQMdUCew4xpvhwwAMz8OpHQzOhemY/buLEfBIDucsRDqcRw9UmakG8KiKCqoT6D48dfSL4GFkgSG0pH8xnPauRxNj6f0sSeIzU6UBE/fH3EP3uAAbsIn7/sPMCfnTjk+LxG45GMTOapugnM= Received: by 10.78.204.20 with SMTP id b20mr3368831hug.1164882505367; Thu, 30 Nov 2006 02:28:25 -0800 (PST) Received: by 10.78.183.12 with HTTP; Thu, 30 Nov 2006 02:28:25 -0800 (PST) Message-ID: <2c9597b90611300228g1c9e46fdw895a3341bfbd2d04@mail.gmail.com> Date: Thu, 30 Nov 2006 13:28:25 +0300 From: "Alexei Zakharov" To: dev@harmony.apache.org Subject: Re: [testing] Swing tests clean up In-Reply-To: <456DC0DF.3070703@pobox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <8E389A5F2FEABA4CB1DEC35A25CB39CE7DB2B5@mssmsx411> <200611290857.40767.chris.gray@kiffer.be> <456D5373.6090302@gmail.com> <200611291001.kATA1Dhh018225@d06av02.portsmouth.uk.ibm.com> <456DC0DF.3070703@pobox.com> X-Virus-Checked: Checked by ClamAV on apache.org > the whitespace really helps signify separate "thoughts", IMO. Exactly. 2006/11/29, Geir Magnusson Jr. : > But I do sympathize with the "don't remove all blank lines" camp - they > don't actually cost any processor cycles, and they really can help > readability. > > I know that is a subjective assessment, but I do find it hard to read > through really white-space-free code - the whitespace really helps > signify separate "thoughts", IMO. > > geir > > Mark Hindess wrote: > > On 29 November 2006 at 9:31, Tim Ellison wrote: > >> Chris Gray wrote: > >>> On Wednesday 29 November 2006 00:03, Alexei Fedotov wrote: > >>>> Nathan, > >>>> You are doing a great job in Swing tests. Non-empty lines you've > >>>> deleted repay triple cost of these empty lines. :-) > >>> There should be a sign above every programmer's desk: "how many > >>> lines of code did you delete today?" :-) > >>> > >>> I'm serious - every line of code represents CPU cycles, footprint, > >>> and worst of all potential bugs. Every time we make a real > >>> improvement in Mika we end > >>> up with less code than when we started. > >> That's my mantra too. It gives me great pleasure to remove > >> unnecessary chunks and simplify code. > > > > +1 > > > >> Keep up the good work Nathan. > > > > +1. (Thanks for your cleanup of the BasicSwingTestCase dependency.) -- Alexei Zakharov, Intel Enterprise Solutions Software Division