Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 16178 invoked from network); 28 Nov 2006 16:06:15 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 28 Nov 2006 16:06:15 -0000 Received: (qmail 18624 invoked by uid 500); 28 Nov 2006 16:06:21 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 18463 invoked by uid 500); 28 Nov 2006 16:06:21 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 18453 invoked by uid 99); 28 Nov 2006 16:06:21 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Nov 2006 08:06:20 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of alexei.zakharov@gmail.com designates 72.14.214.225 as permitted sender) Received: from [72.14.214.225] (HELO hu-out-0506.google.com) (72.14.214.225) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Nov 2006 08:06:09 -0800 Received: by hu-out-0506.google.com with SMTP id 28so2803561hug for ; Tue, 28 Nov 2006 08:05:48 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=G/DDPDLpYdJnjMdIi5oPOZQg6+96Z9fPqUWcHlAzws6eyW/p1MTUA8hQS0YqPbkWA8BtNF7AEDTWtNAi8Fe62upGWwEIFoAvarMLDIqwg27bCuHoP9sihjFeB0SPsJU6EOYdbBoJwO6rSEG7t+9daHt9AXa7hICbDtClId/Krkg= Received: by 10.78.128.15 with SMTP id a15mr1080075hud.1164729947534; Tue, 28 Nov 2006 08:05:47 -0800 (PST) Received: by 10.78.183.12 with HTTP; Tue, 28 Nov 2006 08:05:47 -0800 (PST) Message-ID: <2c9597b90611280805p42a92e4ybc3a26a09c0718f2@mail.gmail.com> Date: Tue, 28 Nov 2006 19:05:47 +0300 From: "Alexei Zakharov" To: dev@harmony.apache.org, geir@pobox.com Subject: Re: svn commit: r479913 - in /harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo: AbstractUndoableEditTest.java CannotRedoExceptionTest.java CannotUndoExceptionTest.java In-Reply-To: <456BDC43.2090802@pobox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20061128053133.719F81A9846@eris.apache.org> <456BD41B.3080407@pobox.com> <3b3f27c60611272224o10be1898k8acffeada926a412@mail.gmail.com> <906dd82e0611272247v4a8a7c20qa56fe8e9588e74ce@mail.gmail.com> <456BDC43.2090802@pobox.com> X-Virus-Checked: Checked by ClamAV on apache.org IMHO main() as well as suite() can be useful so I always left it in the code. At least the last one. Regards, 2006/11/28, Geir Magnusson Jr. : > But that gets to be a pain - my thought is that unless it's harmful or > misleading, what's the problem with leaving it there? And to belabor > the point, its polite to ask... > > geir > > > Mikhail Loenko wrote: > > I usually do this. But I'm able to add main back when I need :) > > +1 for removing > > > > 2006/11/28, Nathan Beyer : > >> To make the tests consistent with the majority (my observation) of the > >> other Harmony test cases without them. > >> > >> Besides that, from a pragmatic view, it's never used. The caveat to > >> that might be that lone hacker doing everything from the command-line > >> and invoking individual tests, if they have main methods, via a "java > >> ..." command. > >> > >> -Nathan > >> > >> On 11/28/06, Geir Magnusson Jr. wrote: > >> > I'm game - why should the main() be removed? > >> > > >> > geir > >> > > >> > ndbeyer@apache.org wrote: > >> > > Author: ndbeyer > >> > > Date: Mon Nov 27 21:31:26 2006 > >> > > New Revision: 479913 > >> > > > >> > > URL: http://svn.apache.org/viewvc?view=rev&rev=479913 > >> > > Log: > >> > > Remove unnecessary and empty methods > >> > > > >> > > Modified: > >> > > > >> harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/AbstractUndoableEditTest.java > >> > >> > > > >> harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/CannotRedoExceptionTest.java > >> > >> > > > >> harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/CannotUndoExceptionTest.java > >> > >> > > > >> > > Modified: > >> harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/AbstractUndoableEditTest.java > >> > >> > > URL: > >> http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/AbstractUndoableEditTest.java?view=diff&rev=479913&r1=479912&r2=479913 > >> > >> > > > >> ============================================================================== > >> > >> > > --- > >> harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/AbstractUndoableEditTest.java > >> (original) > >> > > +++ > >> harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/AbstractUndoableEditTest.java > >> Mon Nov 27 21:31:26 2006 > >> > > @@ -35,10 +35,6 @@ > >> > > > >> > > private String defaultRedoName; > >> > > > >> > > - public static void main(final String[] args) { > >> > > - junit.textui.TestRunner.run(AbstractUndoableEditTest.class); > >> > > - } > >> > > - > >> > > @Override > >> > > protected void setUp() throws Exception { > >> > > obj = new AbstractUndoableEdit(); > >> > > > >> > > Modified: > >> harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/CannotRedoExceptionTest.java > >> > >> > > URL: > >> http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/CannotRedoExceptionTest.java?view=diff&rev=479913&r1=479912&r2=479913 > >> > >> > > > >> ============================================================================== > >> > >> > > --- > >> harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/CannotRedoExceptionTest.java > >> (original) > >> > > +++ > >> harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/CannotRedoExceptionTest.java > >> Mon Nov 27 21:31:26 2006 > >> > > @@ -14,25 +14,12 @@ > >> > > * See the License for the specific language governing > >> permissions and > >> > > * limitations under the License. > >> > > */ > >> > > -/** > >> > > - * @author Evgeniya G. Maenkova > >> > > - * @version $Revision$ > >> > > - */ > >> > > + > >> > > package javax.swing.undo; > >> > > > >> > > import junit.framework.TestCase; > >> > > > >> > > public class CannotRedoExceptionTest extends TestCase { > >> > > - @Override > >> > > - protected void setUp() throws Exception { > >> > > - super.setUp(); > >> > > - } > >> > > - > >> > > - @Override > >> > > - protected void tearDown() throws Exception { > >> > > - super.tearDown(); > >> > > - } > >> > > - > >> > > public void testCannotRedoException() { > >> > > CannotRedoException exception = new CannotRedoException(); > >> > > assertNull(exception.getMessage()); > >> > > > >> > > Modified: > >> harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/CannotUndoExceptionTest.java > >> > >> > > URL: > >> http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/CannotUndoExceptionTest.java?view=diff&rev=479913&r1=479912&r2=479913 > >> > >> > > > >> ============================================================================== > >> > >> > > --- > >> harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/CannotUndoExceptionTest.java > >> (original) > >> > > +++ > >> harmony/enhanced/classlib/trunk/modules/swing/src/test/api/java/common/javax/swing/undo/CannotUndoExceptionTest.java > >> Mon Nov 27 21:31:26 2006 > >> > > @@ -14,25 +14,12 @@ > >> > > * See the License for the specific language governing > >> permissions and > >> > > * limitations under the License. > >> > > */ > >> > > -/** > >> > > - * @author Evgeniya G. Maenkova > >> > > - * @version $Revision$ > >> > > - */ > >> > > + > >> > > package javax.swing.undo; > >> > > > >> > > import junit.framework.TestCase; > >> > > > >> > > public class CannotUndoExceptionTest extends TestCase { > >> > > - @Override > >> > > - protected void setUp() throws Exception { > >> > > - super.setUp(); > >> > > - } > >> > > - > >> > > - @Override > >> > > - protected void tearDown() throws Exception { > >> > > - super.tearDown(); > >> > > - } > >> > > - > >> > > public void testCannotRedoException() { > >> > > CannotUndoException exception = new CannotUndoException(); > >> > > assertNull(exception.getMessage()); -- Alexei Zakharov, Intel Enterprise Solutions Software Division