Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Received-SPF: neutral (herse.apache.org: 195.212.29.134 is neither permitted
 nor denied by domain of mark.hindess@googlemail.com)
Message-Id: <200611011522.kA1FMd0e010821@d06av02.portsmouth.uk.ibm.com>
In-reply-to: <200611011339.kA1DdvZn027817@d06av02.portsmouth.uk.ibm.com> 
References: <7273946b0610310102x20c80a2fm88d2113a03a7e8fb@mail.gmail.com>
 <454712DA.2050001@gmail.com>
 <b266b8670610310508n5f6295dcj94779cf9e53c428c@mail.gmail.com>
 <e29119980610310618x1479b530m6b7998e7a0cdf3b4@mail.gmail.com>
 <b266b8670610312231t54093d49xdc665515c3b149f3@mail.gmail.com>
 <454878E8.5000800@gmail.com>
 <200611011339.kA1DdvZn027817@d06av02.portsmouth.uk.ibm.com>
Comments: In-reply-to Mark Hindess <mark.hindess@googlemail.com>
   message dated "Wed, 01 Nov 2006 13:39:48 +0000."
From: Mark Hindess <mark.hindess@googlemail.com>
To: harmony-dev@incubator.apache.org
Subject: Re: [security][testing] 2 tests failed today 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Wed, 01 Nov 2006 15:22:31 +0000


On 1 November 2006 at 13:39, Mark Hindess <mark.hindess@googlemail.com> wrote:
> 
> Fixed in r469902.  Turns out the exec was putting double quotes around
> the classpath argument (which might make sense if it was going to a
> shell) but it doesn't for an exec syscall.  This resulted in classes
> being search for in the non-existent directory:
> 
>   "/path/to/modules/luni/bin/test
> 
> rather than:
> 
>   /path/to/modules/luni/bin/test
> 
> Regards,
>  Mark - confused as to why it didn't also fail on windows

Oops.  Tim mentioned that my fixed breaks things on windows.  I've
checked in a better fix that I hope should be more well-defined on all
platforms.  That is, pass the arguments to Runtime.exec as an array not
a string.

Aside: My tests show that the behaviour we saw with the quotes in the
string being passed directly through to the execve syscall is consistent
with the RI.

Regards,
 Mark.

> On 1 November 2006 at 10:37, Tim Ellison <t.p.ellison@gmail.com> wrote:
> > Boris Kuznetsov wrote:
> > > The tests use tests.support.Support_Exec.execJava2() to perform
> > > testing on other JVM. This method uses Runtime.getRuntime().exec() to
> > > run command. You can see command (it looks like java -cp ....
> > > <classname>) in the test's System.out. It woks OK on Win, but produces
> > > NoClassDefFoundError on linux.
> > > Note, the command woks OK in linux sh also.
> > 
> > Yes, I don't think it is the tests for HARMONY-1674 per se that are
> > failing, but they are exposing a problem in the exec -- which is why I
> > haven't rolled back that commit.
> > 
> > I'll keep looking at it, let me know if you see the problem.
> > 
> > Regards,
> > Tim
> > 
> > -- 
> > 
> > Tim Ellison (t.p.ellison@gmail.com)
> > 
>