From harmony-dev-return-18022-apmail-incubator-harmony-dev-archive=incubator.apache.org@incubator.apache.org Thu Nov 02 19:57:49 2006 Return-Path: Delivered-To: apmail-incubator-harmony-dev-archive@www.apache.org Received: (qmail 23312 invoked from network); 2 Nov 2006 19:57:48 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 2 Nov 2006 19:57:48 -0000 Received: (qmail 46270 invoked by uid 500); 2 Nov 2006 19:57:54 -0000 Delivered-To: apmail-incubator-harmony-dev-archive@incubator.apache.org Received: (qmail 46233 invoked by uid 500); 2 Nov 2006 19:57:54 -0000 Mailing-List: contact harmony-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: harmony-dev@incubator.apache.org Delivered-To: mailing list harmony-dev@incubator.apache.org Received: (qmail 46213 invoked by uid 99); 2 Nov 2006 19:57:54 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Nov 2006 11:57:54 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of gcjhd-harmony-dev@m.gmane.org designates 80.91.229.2 as permitted sender) Received: from [80.91.229.2] (HELO ciao.gmane.org) (80.91.229.2) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Nov 2006 11:57:37 -0800 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1GfiYn-0008VL-Uc for harmony-dev@incubator.apache.org; Thu, 02 Nov 2006 20:49:09 +0100 Received: from msfwpr01.ims.intel.com ([62.118.80.132]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 02 Nov 2006 20:49:09 +0100 Received: from gshimansky by msfwpr01.ims.intel.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 02 Nov 2006 20:49:09 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: harmony-dev@incubator.apache.org From: Gregory Shimansky Subject: Re: [drlvm][jvmti][testing] I want to add JVMTI tests to drlvm commit checks Date: Thu, 02 Nov 2006 22:31:00 +0300 Lines: 58 Message-ID: References: <200610302324.34453.gshimansky@gmail.com> <200611020142.48176.gshimansky@gmail.com> <45496E07.1060702@pobox.com> <4549FEDC.7020407@pobox.com> <454A323E.9070307@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: msfwpr01.ims.intel.com User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) In-Reply-To: <454A323E.9070307@pobox.com> Sender: news X-Virus-Checked: Checked by ClamAV on apache.org Geir Magnusson Jr. wrote: > > > Gregory Shimansky wrote: >> Geir >> >> I actually was serious. Probably you were confused, I didn't write >> "build test", I wrote "build smoke.test". The first one works ok, the >> second doesn't. >> >> It happens because "test" (top-level test target) is handled in a >> different way from "smoke.test" (target just for smoke test category) >> target in build.xml. The "smoke.test" target just switches default >> processing target to "smoke.test" and runs "process_components" (which >> in its turn loops over all components). The "test" special handling of >> processing components escapes me, I don't quite understand how it >> works, but it seems to work correctly, without looping. > > I've used them both, and targetted smoke for specific use cases (opt, etc) Hmm you probably know more about VM build than I do since you've been modifying it for quite some time already. I've just started to look into the whole thing. >> >> The question I was trying to solve was, how to correctly add >> jvmti.test target to the build.xml so that it would run only jvmti >> tests but not loop over components, but when "test" target it called, >> jvmti tests category would be executed along with all other categories. >> >> Including "jvmti.test" target into build.xml in the same way as >> "smoke.test" doesn't make me happy. > > Right - I thought you'd start a revolt and do it outside of the "loop > over test types" system we have now. Well I am not an ant guru, and the current build system definitely requires some time to understand. I've tried to copy most of the stuff from other test ant files to make my own. I think I'll file a JIRA before committing it to make it possible to discuss it. > In order to keep this simple, why not just have a separate test target > for now > > $ sh build.sh test.jvmti > > and we can stare at that together, and figure out how to integrate... > simplest thing would be to rename the current "test" target to > "test_loop" or something, and then > > > > :) Hmm good idea, why didn't I think of it myself?... :) -- Gregory