harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Varlamov" <alexey.v.varla...@gmail.com>
Subject Re: [drlvm][test]Exclude some tests from "build test" target, make 'build test' pass
Date Tue, 14 Nov 2006 06:51:00 GMT
2006/11/14, Gregory Shimansky <gshimansky@gmail.com>:
> On Monday 13 November 2006 15:51 Elena Semukhina wrote:
> > On 10/26/06, Elena Semukhina <elena.semukhina@gmail.com> wrote:
> > > After H-1823 has been committed, I still see intermittent failures of
> > > drlvm kernel ThreadTest. Normally this test passes but today I got
> > > ThreadTest.testInterrupt_Sleeping() and testGetStateBlocked() failures.
> > > There is H-1789 for the first issue but it is not reprodiced with the
> > > attached test anymore. For the second test I filed H-1876 to make the
> > > test more stable. The patch has been committed recently but the test
> > > still may fail. I'd like someone to review the above mentioned tests to
> > > be sure they are correct otherwise we need to investigate failures and
> > > file JIRA's before the tests are exclued.
> >
> > I looked at ThreadTest again and found one more incorrectness in
> > testGetStateBlocked(): it does not wait for the thread's run() method
> > actually starts. I filed https://issues.apache.org/jira/browse/HARMONY-2166
> > and attached the patch. I ran the test more than 100 times and did not see
> > a failure.
>
> Cool! I'd like to see this patch applied (in case it really helps) ASAP.
> Alexey V, please don't hold it for long. I would really like to see all
> acceptance to pass again on all platforms and then we'll maintain no
> regression state.

Verified and applied (at r474672). BTW, seems we are very close to
100% pass rate for classlib tests on DRLVM. The wiki status page [1]
lists just few pending issues, hopefully we'll fix them all in a
couple of days.

[1] http://wiki.apache.org/harmony/Unit_Tests_Pass_on_DRLVM

Mime
View raw message