harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Salikh Zakirov <Salikh.Zaki...@Intel.com>
Subject Re: [drlvm][threading] questions about wait_count and notify_flag in thread_native_fat_monitor.c
Date Tue, 28 Nov 2006 11:17:21 GMT
Weldon Washburn wrote:
> Your comments helped a bunch.  I now understand this code.  It looks
> correct.   It would be good if you could put more comments in the patch.
> Maybe rephrasing the below would work.   One thing to look out for is a
> race
> condition that allows a thread to miss an intended notify.
> Also the "#ifdef NO_COND_VARS" is very distracting.   Morphing notify_flag
> to notify_count is a good idea.  But I don't see a reason to attempt to
> patch up the NO_COND_VARS use of notify_flag/notify_count.  How about
> tossing all the code inside #ifdef NO_COND_VARS?

tossing NO_COND_VARS is suggested as a next step in cleaning up this code,
in HARMONY-1951 subtasks: see HARMONY-2269

I will post renaming notify_flag -> notify_count and more comments as
subsequent patches on top of HARMONY-1951 and HARMONY-2269.

View raw message