harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gregory Shimansky <gshiman...@gmail.com>
Subject Re: svn commit: r477149 - in /harmony/enhanced/drlvm/trunk/build/make: targets/kernel.test.xml test.properties
Date Tue, 21 Nov 2006 13:16:39 GMT
Geir Magnusson Jr. wrote:
> 
> 
> Gregory Shimansky wrote:
>> Geir Magnusson Jr. wrote:
>>>
>>>
>>> Gregory Shimansky wrote:
>>>>
>>>> I would also like a switch. I don't like it that a change which 
>>>> knowingly introduces problems with acceptance tests is committed 
>>>> without discussion. Should we discard kernel tests from drlvm 
>>>> commits until they are fixed? I think that there was an agreement 
>>>> about no regression. So now all commits to drlvm are blocked.
>>>>
>>>
>>>
>>> Can we just declare that it's time to drive to getting these tests 
>>> fixed????
>>
>> I never wrote that we shouldn't fix these bugs.
> 
> I know.
> 
>> I just complained that instead of breaking things like this, the new 
>> mode could be introduced as an option to allow us to fix tests first, 
>> then switch to it.
> 
> I'm missing something though - what broke because of this change?

Well I assumed that kernel tests crashes on windows XP are because of 
the new mode when all tests are executed in the same VM. When test is 
executed separately it doesn't crash. I am going to try to find the 
problem now.

-- 
Gregory


Mime
View raw message