harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gregory Shimansky <gshiman...@gmail.com>
Subject Re: svn commit: r475473 - /incubator/harmony/enhanced/drlvm/trunk/vm/tests/smoke/StackTest.java
Date Wed, 15 Nov 2006 23:08:22 GMT
Geir Magnusson Jr. wrote:
> I still think that this is bogus....
> 
> What if SOE machinery is broken?
 >
> We need to make this a predictable test.

Well I don't feel strongly to either side. We can use ulimit -s in 
build.sh script which runs tests (maybe only in case it runs tests).

I worry about two things

1. Ulimit is not a shell command, it is a bash setting. Will ulimit -s 
called inside of build.sh affect commands running from it, e.g. ant 
test? I don't want to lose SuSE server again tonight because I don't 
have access to its console, so it will be rebooted only in the morning :)

2. What if the limit on the system is lower than 8192? Ulimit -s allows 
only lower than current setting in a session (otherwise any user could 
increase their limit to any value). So if it is set to something like 
4096 the ulimit -s 8192 command will cause an error.

> gshimansky@apache.org wrote:
>> Author: gshimansky
>> Date: Wed Nov 15 14:38:55 2006
>> New Revision: 475473
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=475473
>> Log:
>> Allow the test to pass even when no SOE happens in max_depth recursions
>>
>>
>> Modified:
>>     incubator/harmony/enhanced/drlvm/trunk/vm/tests/smoke/StackTest.java
>>
>> Modified: 
>> incubator/harmony/enhanced/drlvm/trunk/vm/tests/smoke/StackTest.java
>> URL: 
>> http://svn.apache.org/viewvc/incubator/harmony/enhanced/drlvm/trunk/vm/tests/smoke/StackTest.java?view=diff&rev=475473&r1=475472&r2=475473

>>
>> ============================================================================== 
>>
>> --- 
>> incubator/harmony/enhanced/drlvm/trunk/vm/tests/smoke/StackTest.java 
>> (original)
>> +++ 
>> incubator/harmony/enhanced/drlvm/trunk/vm/tests/smoke/StackTest.java 
>> Wed Nov 15 14:38:55 2006
>> @@ -29,11 +29,10 @@
>>      public static void main(String[] args) {
>>          try {
>>              func();
>> -            System.out.println("FAIL");
>>          } catch (StackOverflowError soe) {
>>              System.out.println("PASS : First SOE depth = " + depth + 
>> " : " + soe);
>>              return;
>>          }
>> -        System.out.println("FAIL: no SOE in " + max_depth + " 
>> iterations");
>> +        System.out.println("PASS: no SOE in " + max_depth + " 
>> iterations");
>>      }
>>  }
>>
>>
>>
> 


-- 
Gregory


Mime
View raw message