harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Elena Semukhina" <elena.semukh...@gmail.com>
Subject Re: [drlvm][test]Exclude some tests from "build test" target, make 'build test' pass
Date Thu, 16 Nov 2006 09:57:14 GMT
Thank you, Gregory!

On 11/15/06, Gregory Shimansky <gshimansky@gmail.com> wrote:
>
> Elena Semukhina wrote:
> > I've found one more issue in the kernel ThreadTest. Filed
> > https://issues.apache.org/jira/browse/HARMONY-2193.
> >
> > Alexey, please take a look!
>
> I am not an Alexey, but I assigned this JIRA to myself. The testcase
> seems to be working both on linux and windows, I committed the patch.
>
> > On 11/14/06, Alexey Varlamov <alexey.v.varlamov@gmail.com> wrote:
> >>
> >> 2006/11/14, Gregory Shimansky <gshimansky@gmail.com>:
> >> > On Monday 13 November 2006 15:51 Elena Semukhina wrote:
> >> > > On 10/26/06, Elena Semukhina <elena.semukhina@gmail.com> wrote:
> >> > > > After H-1823 has been committed, I still see intermittent
> failures
> >> of
> >> > > > drlvm kernel ThreadTest. Normally this test passes but today
I
> got
> >> > > > ThreadTest.testInterrupt_Sleeping() and testGetStateBlocked()
> >> failures.
> >> > > > There is H-1789 for the first issue but it is not reprodiced
with
> >> the
> >> > > > attached test anymore. For the second test I filed H-1876 to
make
> >> the
> >> > > > test more stable. The patch has been committed recently but the
> >> test
> >> > > > still may fail. I'd like someone to review the above mentioned
> >> tests
> >> to
> >> > > > be sure they are correct otherwise we need to investigate
> failures
> >> and
> >> > > > file JIRA's before the tests are exclued.
> >> > >
> >> > > I looked at ThreadTest again and found one more incorrectness in
> >> > > testGetStateBlocked(): it does not wait for the thread's run()
> method
> >> > > actually starts. I filed
> >> https://issues.apache.org/jira/browse/HARMONY-2166
> >> > > and attached the patch. I ran the test more than 100 times and did
> >> not
> >> see
> >> > > a failure.
> >> >
> >> > Cool! I'd like to see this patch applied (in case it really helps)
> >> ASAP.
> >> > Alexey V, please don't hold it for long. I would really like to see
> all
> >> > acceptance to pass again on all platforms and then we'll maintain no
> >> > regression state.
> >>
> >> Verified and applied (at r474672). BTW, seems we are very close to
> >> 100% pass rate for classlib tests on DRLVM. The wiki status page [1]
> >> lists just few pending issues, hopefully we'll fix them all in a
> >> couple of days.
> >>
> >> [1] http://wiki.apache.org/harmony/Unit_Tests_Pass_on_DRLVM
> >>
> >
> >
> >
>
>
> --
> Gregory
>
>


-- 
Thanks,
Elena

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message