harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Petrenko" <alexey.a.petre...@gmail.com>
Subject Re: svn commit: r478636 - in /harmony/enhanced/classlib/trunk/modules/awt/src/main/java/common/java/awt: Canvas.java Component.java Font.java MenuComponent.java Toolkit.java Window.java geom/Area.java
Date Fri, 24 Nov 2006 07:31:55 GMT
2006/11/23, Tim Ellison <t.p.ellison@gmail.com>:
> apetrenko@apache.org wrote:
> > -    public void add(Area area) {
> > +    public void add(Area area) throws org.apache.harmony.luni.util.NotImplementedException
{
> >          throw new RuntimeException("Not implemented"); //$NON-NLS-1$
> >      }
> Sorry if I'm getting annoying ;-) but why not :
> (1) import the NotYetImplementedException like we do everywhere else for
> type we reference, and
It's just easier to remove. Remove it soon I hope :)

> (2) actually throw it rather than a generic RuntimeException?
What for? User will see that the method is not implemented anyway :)
japitools does not look inside.
It does not matter anyway.

Mime
View raw message