harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Petrenko" <alexey.a.petre...@gmail.com>
Subject Re: [testing] test exclude list: can't we have incremental exclusions?
Date Thu, 23 Nov 2006 15:53:25 GMT
+1 for this change.
6 exclude files per module is too much!

SY, Alexey

23.11.06, Ivanov, Alexey A<alexey.a.ivanov@intel.com> написал(а):
> Hi everyone,
>
> Recently test exclude lists were removed from build.xml of the corresponding module,
and there were added *six* files with excluded tests. These files contain almost the same
list of files. The lists are identical for swing module. I found 2 differences for awt module
(there are still about 50 files names listed in every of the exclude lists).
>
> Why can't we use one 'exclude.all' file to exclude tests which fail on every platform?
It's an obvious optimization.
> I've tested the approach of using several exclude list files on build.xml of swing module.
It works just fine.
>
> Your comments?
>
> Regards,
> Alexey.
>
>
> ----- build.xml patch --------
> Index: build.xml
> ===================================================================
> --- build.xml   (revision 478584)
> +++ build.xml   (working copy)
> @@ -186,6 +186,7 @@
>
>                  <fileset dir="${hy.swing.src.test.api}/java/common">
>                      <include name="**/*Test*.java"/>
> +                       <excludesfile name="./make/exclude.all" />
>                      <excludesfile name="${exclude.file}" />
>                  </fileset>
>              </batchtest>
> ------------------------------
>
>
> --
> Alexey A. Ivanov
> Intel EnterpriseSolutions SoftwareDivision
>
Mime
View raw message