harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ivanov, Alexey A" <alexey.a.iva...@intel.com>
Subject RE: [testing] Swing tests clean up
Date Tue, 28 Nov 2006 08:00:47 GMT
And another point for not performing "unnecessary" reformatting is there
may be JIRA issues with patches to tests: to add a new test, to fix a
problem. It'll be hard to apply them after such reformatting.

Regards,
--
Alexey A. Ivanov
Intel Enterprise Solutions Software Division


>-----Original Message-----
>From: Nathan Beyer [mailto:nbeyer@gmail.com]
>Sent: Tuesday, November 28, 2006 8:01 AM
>To: dev@harmony.apache.org
>Subject: Re: [testing] Swing tests clean up
>
>Sorry. I guess my formatting was over aggressive while eliminating the
>compiler warnings. Note, not EVERY empty line was eliminated, just
>those within methods. I actually added a number of lines between
>methods, classes, etc.
>
>Personal, I didn't think that the tests are any less readable. I would
>argue that if a test method needs to be separated visually, then the
>method should be split up into multiple methods.
>
>-Nathan
>
>On 11/27/06, Ivanov, Alexey A <alexey.a.ivanov@intel.com> wrote:
>> Nathan,
>>
>>
>>
>> Do you thing empty lines in tests are useless? Why have you removed
>> every single empty line in tests?
>>
>> They were there on purpose! They separate parts of a unit test. I
don't
>> want them to be dropped! The code is unreadable without them.
>>
>>
>>
>> Thank you in advance,
>>
>> Alexey.
>>
>>
>>
>> --
>> Alexey A. Ivanov
>> Intel Enterprise Solutions Software Division
>>
>>
>>
>>
>>

Mime
View raw message