harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stepan Mishura" <stepan.mish...@gmail.com>
Subject Re: [testing] Swing tests clean up
Date Wed, 29 Nov 2006 08:15:26 GMT
On 11/29/06, Mikhail Loenko wrote:
>
> Some time ago we agreed to follow Apache conventions. It was even an
> style attached to someones mail. I'm for automatic formatting for the
> following reason:
> we have a bunch of people here and each of them always follows his
> favorite
> convention.
>
> But we do a common project and have to follow a common convention...


+1

-Stepan.

Thanks,
> Mikhail
>
> 2006/11/28, Ivanov, Alexey A <alexey.a.ivanov@intel.com>:
> > >-----Original Message-----
> > >From: Alexei Zakharov [mailto:alexei.zakharov@gmail.com]
> > >Sent: Tuesday, November 28, 2006 7:22 PM
> > >To: dev@harmony.apache.org
> > >Subject: Re: [testing] Swing tests clean up
> > >
> > >BTW, Sun Code conventions for Java language explicitly states that we
> > >*should* place blank lines even inside methods in the following cases
> > >[1]:
> > >
> > >- Between the local variables in a method and its first statement
> > >- Before a block or single-line comment
> > >- Between logical sections inside a method to improve readability
> > >
> > >Personally I always try to follow this conventions if it possible.
> >
> > I always follow Sun Java Coding Style Guidelines (where it makes sense).
> > And I don't like the results of automatic code formatting.
> >
> > Regards,
> > Alexey.
> >
> > >
> > >[1]
> > http://java.sun.com/docs/codeconv/html/CodeConventions.doc7.html#487
> > >
> > >Thanks,
> > >
> > >2006/11/28, Ivanov, Alexey A <alexey.a.ivanov@intel.com>:
> > >> And another point for not performing "unnecessary" reformatting is
> > there
> > >> may be JIRA issues with patches to tests: to add a new test, to fix a
> > >> problem. It'll be hard to apply them after such reformatting.
> > >>
> > >> Regards,
> > >> --
> > >> Alexey A. Ivanov
> > >> Intel Enterprise Solutions Software Division
> > >>
> > >>
> > >> >-----Original Message-----
> > >> >From: Nathan Beyer [mailto:nbeyer@gmail.com]
> > >> >Sent: Tuesday, November 28, 2006 8:01 AM
> > >> >To: dev@harmony.apache.org
> > >> >Subject: Re: [testing] Swing tests clean up
> > >> >
> > >> >Sorry. I guess my formatting was over aggressive while eliminating
> > the
> > >> >compiler warnings. Note, not EVERY empty line was eliminated, just
> > >> >those within methods. I actually added a number of lines between
> > >> >methods, classes, etc.
> > >> >
> > >> >Personal, I didn't think that the tests are any less readable. I
> > would
> > >> >argue that if a test method needs to be separated visually, then the
> > >> >method should be split up into multiple methods.
> > >> >
> > >> >-Nathan
> > >> >
> > >> >On 11/27/06, Ivanov, Alexey A <alexey.a.ivanov@intel.com> wrote:
> > >> >> Nathan,
> > >> >>
> > >> >>
> > >> >>
> > >> >> Do you thing empty lines in tests are useless? Why have you
> > removed
> > >> >> every single empty line in tests?
> > >> >>
> > >> >> They were there on purpose! They separate parts of a unit test.
I
> > >> don't
> > >> >> want them to be dropped! The code is unreadable without them.
> > >
> > >
> > >--
> > >Alexei Zakharov,
> > >Intel Enterprise Solutions Software Division
> >
> > --
> > Alexey A. Ivanov
> > Intel Enterprise Solutions Software Division
> >
>



-- 
Stepan Mishura
Intel Enterprise Solutions Software Division

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message